Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symmetry number calculation capability #190

Open
googhgoo opened this issue Sep 25, 2021 · 1 comment
Open

Symmetry number calculation capability #190

googhgoo opened this issue Sep 25, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@googhgoo
Copy link
Member

With the atomic structure of the molecule, we can automatically calculate the symmetry number, which is currently not automated. I'm automatically calculating it using pymatgen and a look up table. It could be a great addition to pMutt to add this functionality. A note is that calculating symmetry is not a trivial task, so it would save a significant time to just use pymatgen function (thus we need to consider adding another dependency). If anybody can give me some direction, I can implement the code.

@googhgoo googhgoo added the enhancement New feature or request label Sep 25, 2021
@jonlym
Copy link
Member

jonlym commented Oct 8, 2021

That sounds super useful!

I'd suggest adding lines to pmutt.statmech.rot.RigidRotor along the lines of:

if symmetrynumber == 'pymatgen':
    symmetrynumber = get_symmetry_number_from_pymatgen(atoms)

Then add the required version of pymatgen to setup.py.

Then you can submit a pull request to the development branch and we can iterate from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants