From ab9444e0c26df1f2acfb83bb47bb64acefec437a Mon Sep 17 00:00:00 2001 From: Jarek Potiuk Date: Thu, 18 Apr 2024 12:14:43 +0200 Subject: [PATCH] Switch committer builds to public runners (#39106) Following the discussion on devlist, we are switching committer buids to public runners. Discussion: * https://lists.apache.org/thread/f2kxdjm12nf2rh0tqxmv3rj49sjd6c3w --- .../airflow_breeze/utils/selective_checks.py | 5 +---- dev/breeze/tests/test_selective_checks.py | 20 +++++++++---------- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/dev/breeze/src/airflow_breeze/utils/selective_checks.py b/dev/breeze/src/airflow_breeze/utils/selective_checks.py index ee12f2881c10c..6b42d9134673a 100644 --- a/dev/breeze/src/airflow_breeze/utils/selective_checks.py +++ b/dev/breeze/src/airflow_breeze/utils/selective_checks.py @@ -1090,10 +1090,7 @@ def runs_on_as_json_default(self) -> str: if USE_SELF_HOSTED_RUNNERS_LABEL in self._pr_labels: # Forced self-hosted runners return RUNS_ON_SELF_HOSTED_RUNNER - if actor in COMMITTERS: - return RUNS_ON_SELF_HOSTED_RUNNER - else: - return RUNS_ON_PUBLIC_RUNNER + return RUNS_ON_PUBLIC_RUNNER return RUNS_ON_PUBLIC_RUNNER @cached_property diff --git a/dev/breeze/tests/test_selective_checks.py b/dev/breeze/tests/test_selective_checks.py index 099478ea9c982..e2ee1f0a6b05f 100644 --- a/dev/breeze/tests/test_selective_checks.py +++ b/dev/breeze/tests/test_selective_checks.py @@ -1700,13 +1700,13 @@ def test_helm_tests_trigger_ci_build(files: tuple[str, ...], expected_outputs: d "apache/airflow", (), dict(), - '["self-hosted", "Linux", "X64"]', - "true", - "true", - "true", + '["ubuntu-22.04"]', + "false", "false", "true", "false", + "false", + "false", False, id="Pull request committer", ), @@ -1780,13 +1780,13 @@ def test_helm_tests_trigger_ci_build(files: tuple[str, ...], expected_outputs: d "apache/airflow", [], dict(), - '["self-hosted", "Linux", "X64"]', - "true", - "true", - "true", + '["ubuntu-22.04"]', + "false", "false", "true", "false", + "false", + "false", False, id="Pull request target committer", ), @@ -2065,7 +2065,7 @@ def test_mypy_matches( ("README.md",), { "is-committer-build": "true", - "runs-on-as-json-default": '["self-hosted", "Linux", "X64"]', + "runs-on-as-json-default": '["ubuntu-22.04"]', }, "potiuk", (), @@ -2075,7 +2075,7 @@ def test_mypy_matches( ("README.md",), { "is-committer-build": "false", - "runs-on-as-json-default": '["self-hosted", "Linux", "X64"]', + "runs-on-as-json-default": '["ubuntu-22.04"]', }, "potiuk", ("non committer build",),