Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt is too strict #489

Open
Lex-DRL opened this issue Oct 13, 2024 · 1 comment
Open

requirements.txt is too strict #489

Lex-DRL opened this issue Oct 13, 2024 · 1 comment

Comments

@Lex-DRL
Copy link

Lex-DRL commented Oct 13, 2024

The node pack conflicts with a plenty of other nodes, because it requires:

  • fairscale>=0.4.4 (conflicts with any node using any version of torchscale)
  • opencv-python-headless[ffmpeg]<=4.7.0.72 (conflicts with opencv-python>=4.7.0.72 in comfyui_controlnet_aux and albumentations>=1.4.10 in ComfyUI-AdvancedLivePortrait)

Are these dependencies up to date? Does the node pack actually needs these specific versions?

ERROR: Cannot install fairscale>=0.4.4, torchscale==0.1.0, torchscale==0.1.1, torchscale==0.1.2, torchscale==0.2.0 and torchscale==0.3.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested fairscale>=0.4.4
    torchscale 0.3.0 depends on fairscale==0.4.0
    The user requested fairscale>=0.4.4
    torchscale 0.2.0 depends on fairscale==0.4.0
    The user requested fairscale>=0.4.4
    torchscale 0.1.2 depends on fairscale==0.4.0
    The user requested fairscale>=0.4.4
    torchscale 0.1.1 depends on fairscale==0.4.0
    The user requested fairscale>=0.4.4
    torchscale 0.1.0 depends on fairscale==0.4.0
ERROR: Cannot install albumentations==1.4.10, albumentations==1.4.11, albumentations==1.4.12, albumentations==1.4.13, albumentations==1.4.14, albumentations==1.4.15, albumentations==1.4.16, albumentations==1.4.17, albumentations==1.4.18 and opencv-python-headless<=4.7.0.72 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested opencv-python-headless<=4.7.0.72
    albumentations 1.4.18 depends on opencv-python-headless>=4.9.0.80
    The user requested opencv-python-headless<=4.7.0.72
    albumentations 1.4.17 depends on opencv-python-headless>=4.9.0.80
    The user requested opencv-python-headless<=4.7.0.72
    albumentations 1.4.16 depends on opencv-python-headless>=4.9.0.80
    The user requested opencv-python-headless<=4.7.0.72
    albumentations 1.4.15 depends on opencv-python-headless>=4.9.0.80
    The user requested opencv-python-headless<=4.7.0.72
    albumentations 1.4.14 depends on opencv-python-headless>=4.9.0.80
    The user requested opencv-python-headless<=4.7.0.72
    albumentations 1.4.13 depends on opencv-python-headless>=4.9.0.80
    The user requested opencv-python-headless<=4.7.0.72
    albumentations 1.4.12 depends on opencv-python-headless>=4.9.0.80
    The user requested opencv-python-headless<=4.7.0.72
    albumentations 1.4.11 depends on opencv-python-headless>=4.9.0.80
    The user requested opencv-python-headless<=4.7.0.72
    albumentations 1.4.10 depends on opencv-python-headless>=4.9.0.80
@Lex-DRL
Copy link
Author

Lex-DRL commented Oct 14, 2024

To clarify: I'm not claiming the requirements are redundant. I'm just pointing at the issue: in my experience, for many months WAS node suite was the only custom node (out of a few dozens) which constantly breaks the entire venv in both Windows (11) and Linux (Manjaro).

It leads to an undesired dilemma: EITHER a user installs WAS node suite OR a plenty of other nodes. And I believe, we all know the outcome.

For reference, here's a list of nodes in my installation (to me, all of them seem pretty essential):

cg-use-everywhere
comfy-image-saver
ComfyUI-AdvancedLivePortrait
ComfyUI-Crystools
ComfyUI-Custom-Scripts
ComfyUI-HQ-Image-Save
ComfyUI-Impact-Pack
comfyui-inpaint-nodes
ComfyUI-Inspyrenet-Rembg
ComfyUI-KJNodes
ComfyUI-layerdiffuse
ComfyUI-Manager
ComfyUI-SAM2
ComfyUI-Static-Primitives
ComfyUI_Comfyroll_CustomNodes
comfyui_controlnet_aux
ComfyUI_essentials
ComfyUI_ImageProcessing
ComfyUI_JPS-Nodes
ComfyUI_MaraScott_Nodes
ComfyUi_NNLatentUpscale
ComfyUI_smZNodes
ComfyUI_UltimateSDUpscale
comfy_mtb
efficiency-nodes-comfyui
masquerade-nodes-comfyui
rgthree-comfy
SD-Latent-Upscaler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant