Skip to content
This repository has been archived by the owner on Oct 12, 2024. It is now read-only.

French translation po file availlable #105

Open
smeric opened this issue Nov 10, 2020 · 5 comments
Open

French translation po file availlable #105

smeric opened this issue Nov 10, 2020 · 5 comments

Comments

@smeric
Copy link

smeric commented Nov 10, 2020

Is your feature request related to a problem? Please describe.
Not realy a problem... But the plugin may be dificult to use by french people who do not speak a word of english :)

Describe the solution you'd like
You could add a translation file in french if you got one ? I'm not a translator so my translation may not be perfect... Anyway you can find it here if you're interested : https://sebastien-meric.com/files2download/woocommerce-local-pickup-time-fr_FR.po

@smeric
Copy link
Author

smeric commented Nov 20, 2020

I just used translate.wordpress.org to add this translations.

https://translate.wordpress.org/projects/wp-plugins/woocommerce-local-pickup-time-select/stable/fr/default/

@timnolte
Copy link
Member

@smeric excellent thanks for that. I have a backlog of responses and that was going to be my suggestion. I'd like to get away from managing translations with the code base.

@timnolte
Copy link
Member

@smeric I'm seeing a concerning translation here: https://translate.wordpress.org/projects/wp-plugins/woocommerce-local-pickup-time-select/stable/fr/default/?filters%5Bwarnings%5D=yes It would seem you replaced the title of Pickup Time with a long sentence. There may be a need to adjust the code to accommodate the single place where this translation is desired.

@smeric
Copy link
Author

smeric commented Nov 22, 2020

@timnolte well, this one is not so easy as french may be much most verbose than english to say even simple things... I just reduced it a lot but, as I said, I'm not a translator so I'm not sure it's the best translation... anyway it's at least perfectly understandable and better than none at all ;)

@bastienho
Copy link

Hi

I've just validated and fixed (take care about ’ instead of ') all pending translations. Plugin is now 100% translated in french.

Thank you

@bastienho bastienho mentioned this issue Dec 1, 2021
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants