-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial release #1
Conversation
Co-authored-by: Matt <[email protected]>
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
default branch is main so I may have changed it when I was correcting our branch target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some initial nits till I have the utils migrated for you
@TobiTenno did I do it right? |
seems right so far, but I haven't checked out your code yet still >.< unfortunately yields type errors: > @wfcd/[email protected] build:types
> tsc -p tsconfig.declaration.json
index.d.ts:22:38 - error TS2304: Cannot find name 'dynamic'.
22 constructor(profile: Map<String, dynamic>, locale: string);
~~~~~~~
index.d.ts:127:19 - error TS2304: Cannot find name 'ColorMap'.
127 primaryColor: ColorMap;
~~~~~~~~
Found 2 errors in the same file, starting at: index.d.ts:22 |
One of those is my fault on items, and i'm fixing that |
I put dart's dynamic type and when it didn't correct me I just figured it was right, guess the term here is |
also that in JS json are objects |
ci: switch from precommit-hook to husky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this looks good, the tests are decent, not quite the coverage i'd like to see for a net-new project, but it's looking good. if there's any issues with the autorelease, i can go manually release the first version
Yeah was waiting to see if I was doing it right before moving on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good just one suggestion on the inventory spec ^
@TobiTenno hopefully this is what you had in mind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
precisely
What did you fix?
This start the profile-parser project in order to parse the output given by
https://content.warframe.com/dynamic/getProfileViewingData.php?n=${username}
TODOs:
Considerations