Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial release #1

Merged
merged 47 commits into from
Apr 11, 2024
Merged

feat: initial release #1

merged 47 commits into from
Apr 11, 2024

Conversation

SlayerOrnstein
Copy link
Member

@SlayerOrnstein SlayerOrnstein commented Feb 8, 2024

What did you fix?

This start the profile-parser project in order to parse the output given by https://content.warframe.com/dynamic/getProfileViewingData.php?n=${username}

TODOs:

  • tests
  • github actions

Considerations

  • Does this contain a new dependency? Yes
  • Does this introduce opinionated data formatting or manual data entry? Yes
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? No
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Feature

.github/CODEOWNERS Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/Affiliations.js Outdated Show resolved Hide resolved
src/LoadOutWeapon.js Outdated Show resolved Hide resolved
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@TobiTenno TobiTenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some initial nits till I have the utils migrated for you

.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/docs.yaml Outdated Show resolved Hide resolved
src/LoadOutWeapon.js Outdated Show resolved Hide resolved
src/PlayerSummary.js Outdated Show resolved Hide resolved
src/PlayerSummary.js Outdated Show resolved Hide resolved
test/unit/mock.spec.js Outdated Show resolved Hide resolved
@SlayerOrnstein
Copy link
Member Author

@TobiTenno did I do it right?

@TobiTenno
Copy link
Member

TobiTenno commented Mar 21, 2024

seems right so far, but I haven't checked out your code yet still >.<

unfortunately yields type errors:

> @wfcd/[email protected] build:types
> tsc -p tsconfig.declaration.json

index.d.ts:22:38 - error TS2304: Cannot find name 'dynamic'.

22     constructor(profile: Map<String, dynamic>, locale: string);
                                        ~~~~~~~

index.d.ts:127:19 - error TS2304: Cannot find name 'ColorMap'.

127     primaryColor: ColorMap;
                      ~~~~~~~~


Found 2 errors in the same file, starting at: index.d.ts:22

@TobiTenno
Copy link
Member

One of those is my fault on items, and i'm fixing that

@SlayerOrnstein
Copy link
Member Author

seems right so far, but I haven't checked out your code yet still >.<

unfortunately yields type errors:

> @wfcd/[email protected] build:types
> tsc -p tsconfig.declaration.json

index.d.ts:22:38 - error TS2304: Cannot find name 'dynamic'.

22     constructor(profile: Map<String, dynamic>, locale: string);
                                        ~~~~~~~

index.d.ts:127:19 - error TS2304: Cannot find name 'ColorMap'.

127     primaryColor: ColorMap;
                      ~~~~~~~~


Found 2 errors in the same file, starting at: index.d.ts:22

I put dart's dynamic type and when it didn't correct me I just figured it was right, guess the term here is any?

@SlayerOrnstein
Copy link
Member Author

also that in JS json are objects

TobiTenno
TobiTenno previously approved these changes Mar 21, 2024
Copy link
Member

@TobiTenno TobiTenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good, the tests are decent, not quite the coverage i'd like to see for a net-new project, but it's looking good. if there's any issues with the autorelease, i can go manually release the first version

@SlayerOrnstein
Copy link
Member Author

Yeah was waiting to see if I was doing it right before moving on

test/unit/mock.spec.js Outdated Show resolved Hide resolved
@SlayerOrnstein SlayerOrnstein changed the title feat: initial start of the profile parser feat: initial release Apr 9, 2024
@SlayerOrnstein SlayerOrnstein enabled auto-merge (squash) April 10, 2024 00:00
TobiTenno

This comment was marked as outdated.

@TobiTenno TobiTenno disabled auto-merge April 10, 2024 23:32
Copy link
Member

@TobiTenno TobiTenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good just one suggestion on the inventory spec ^

@TobiTenno TobiTenno enabled auto-merge (squash) April 10, 2024 23:33
@SlayerOrnstein
Copy link
Member Author

@TobiTenno hopefully this is what you had in mind

Copy link
Member

@TobiTenno TobiTenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

precisely

@TobiTenno TobiTenno merged commit 4ba1c17 into main Apr 11, 2024
8 checks passed
@SlayerOrnstein SlayerOrnstein deleted the intial-start branch April 11, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants