Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run npm install before jsdoc and minor document changes #3

Merged
merged 1 commit into from
Apr 11, 2024
Merged

ci: run npm install before jsdoc and minor document changes #3

merged 1 commit into from
Apr 11, 2024

Conversation

SlayerOrnstein
Copy link
Member

What did you fix?

Cleaned up jsdoc to use the module syntax instead and run npm install before running jsdoc

Reproduction steps

Evidence/screenshot/link to line

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? Yes
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? Yes
  • Have I run the linter? No
  • Is is a bug fix, feature request, or enhancement? Docs

@SlayerOrnstein SlayerOrnstein requested a review from a team as a code owner April 11, 2024 03:53
@TobiTenno TobiTenno enabled auto-merge (squash) April 11, 2024 03:58
@TobiTenno TobiTenno merged commit a2ae735 into main Apr 11, 2024
8 checks passed
@TobiTenno TobiTenno deleted the fix_release branch April 11, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiTenno TobiTenno TobiTenno approved these changes

@EricSihaoLin EricSihaoLin Awaiting requested review from EricSihaoLin EricSihaoLin is a code owner automatically assigned from WFCD/node-libraries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SlayerOrnstein @TobiTenno