Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linter): add isort & black #12

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

leonardodalinky
Copy link
Contributor

@leonardodalinky leonardodalinky commented Sep 25, 2023

Configs for isort and black are placed in pyproject.toml.
Pre-commit hooks are set.
Github action workflow lint is also added. Only checked push are permitted to trigger a release.
Add CONTRIBUTE.md as guidelines.

Not being tested yet.


Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? No
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? No
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Maintenance

Configs for `isort` and `black` are placed in `pyproject.toml`
Pre-commit hooks are set.
Github action workflow `lint` is also added. Only checked push are
permitted to trigger a release.
Copy link
Collaborator

@Mettwasser Mettwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@leonardodalinky
Copy link
Contributor Author

Looks like the Github Action works now.

@Mettwasser Mettwasser merged commit a481549 into WFCD:main Sep 26, 2023
2 checks passed
leonardodalinky added a commit that referenced this pull request Sep 26, 2023
* chore(linter): add isort & black

Configs for `isort` and `black` are placed in `pyproject.toml`
Pre-commit hooks are set.
Github action workflow `lint` is also added. Only checked push are
permitted to trigger a release.

* chore(linter): updating exsiting files
Mettwasser pushed a commit that referenced this pull request Sep 28, 2023
* chore(linter): add isort & black

Configs for `isort` and `black` are placed in `pyproject.toml`
Pre-commit hooks are set.
Github action workflow `lint` is also added. Only checked push are
permitted to trigger a release.

* chore(linter): updating exsiting files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants