Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-type argument in local-to-global transformations #62

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Da-Be-Ru
Copy link
Member

@Da-Be-Ru Da-Be-Ru commented Oct 9, 2024

The local-to-global eval_trafo! functions currently operate on the Vector type.

However, in trying to extend VoronoiFVM.edgevelocities to accomodate velocity fields provided by ExtendableFEM.jl, we need to make use of coordinate transformations on vectors previously declared as StaticArrays which are not a subtype of Vector.

It makes sense to adjust the type of x then and I suppose AbstractArray is a safe bet. All tests run through for me on this.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.73%. Comparing base (06a2f11) to head (eee8d7d).
Report is 86 commits behind head on master.

Files with missing lines Patch % Lines
src/l2gtransformations.jl 42.85% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   73.01%   73.73%   +0.71%     
==========================================
  Files          27       32       +5     
  Lines        4239     4907     +668     
==========================================
+ Hits         3095     3618     +523     
- Misses       1144     1289     +145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-fu
Copy link
Member

j-fu commented Oct 9, 2024

Completely reasonable IMHO, thanks! @chmerdon , we should merge and make a new patch version.

@j-fu j-fu merged commit 44e9ab3 into WIAS-PDELib:master Oct 9, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants