Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLMakie: Annotate cell/boundary region color bar #38

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

pjaap
Copy link
Member

@pjaap pjaap commented Nov 18, 2024

After using gridplot with GLMakie for a while I asked myself why

I think the users may use the grid plot to determine the indices and total number of cell/boundary regions by looking at the gridplot.

With this proposed changes, together with WIAS-PDELib/GridVisualizeTools.jl#9, the result looks like this

Screenshot_20241118_124857

@pjaap
Copy link
Member Author

pjaap commented Nov 18, 2024

2D example:
Screenshot_20241118_125723

@j-fu
Copy link
Member

j-fu commented Nov 18, 2024

I left out these text labels for reasons of screen real estate for the case we have several plots in one window (via the layout stuff). May be we could make these optional, or even make the colorbars optional (which I guess is easier to organize).

Also: how do PyPlot and PlutoVista behave ? We can safely ignore Plots, because this misses decent handling of triangles - at least when I looked last time.

@pjaap
Copy link
Member Author

pjaap commented Nov 18, 2024

I understand that the labels require some space. However, without a label these bars are not suitable for scientific plots. I would suggest to include the labels and add a kwarg to deactivate the display of the color bars.

@pjaap
Copy link
Member Author

pjaap commented Nov 18, 2024

We should discuss the issue with the concrete number of labels at WIAS-PDELib/GridVisualizeTools.jl#9.

@pjaap pjaap marked this pull request as draft November 18, 2024 12:24
@pjaap pjaap mentioned this pull request Nov 20, 2024
@pjaap pjaap force-pushed the feature/glmakie-label-regions branch from d4e509c to c1c9cc0 Compare November 27, 2024 10:37
@pjaap pjaap marked this pull request as ready for review November 27, 2024 10:37
@pjaap
Copy link
Member Author

pjaap commented Nov 27, 2024

Rebased. This is now ready.

@pjaap pjaap force-pushed the feature/glmakie-label-regions branch from c1c9cc0 to 6f7d4f3 Compare November 27, 2024 14:18
@pjaap
Copy link
Member Author

pjaap commented Nov 27, 2024

Rebased again on top of #39.

@jpthiele jpthiele merged commit e5a3c6b into main Nov 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants