-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendors Signal Feedback Cycle 1 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress
|
naugtur
reviewed
Sep 12, 2024
naugtur
reviewed
Sep 12, 2024
|
||
### Privacy | ||
|
||
This feature doesn't provide any information about the user, and hence doesn't have privacy aspects to consider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
This feature doesn't provide any information about the user, and hence doesn't have privacy aspects to consider. | |
This feature doesn't provide any information about the user, and hence doesn't have privacy aspects to consider. | |
It is limited to Same Origin Realms therefore offers no new ways to track the user. |
naugtur
reviewed
Sep 12, 2024
naugtur
reviewed
Sep 12, 2024
naugtur
reviewed
Sep 12, 2024
README.md
Outdated
In that context, it might be worth reflecting possible alternatives and their pros and cons: | ||
|
||
1. CSP (via header) - introduce `init-realm` via a CSP header (current proposal's state) | ||
* PRO - a capability preserved to the web app (which is the entity expected to be capable of controling such power) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* PRO - a capability preserved to the web app (which is the entity expected to be capable of controling such power) | |
* PRO - a capability reserved to the web app (which is the entity expected to be capable of controlling such power) |
naugtur
reviewed
Sep 12, 2024
README.md
Outdated
* PRO - a capability preserved to the web app (which is the entity expected to be capable of controling such power) | ||
* CON - if the web app mistakenly allows other entities to control headers, this feature can allow them to introduce XSS (unprecedented) | ||
2. CSP (via meta) - introduce `init-realm` via a meta tag | ||
* PRO - Better than a header in the sense that transitioning from a headers' setting capability to XSS is unprecedented and quite an escalation, but if attackers need to be able to modify the initial HTML of the app to transition to XSS, that is (1) more unlikely and (2) less of an escalation (if they can inject HTML tags, they might as well inject a script or an iframe). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* PRO - Better than a header in the sense that transitioning from a headers' setting capability to XSS is unprecedented and quite an escalation, but if attackers need to be able to modify the initial HTML of the app to transition to XSS, that is (1) more unlikely and (2) less of an escalation (if they can inject HTML tags, they might as well inject a script or an iframe). | |
* PRO - Better than a header in the sense that escalating from controlling headers to XSS is unprecedented, but if attackers need to be able to modify the initial HTML of the app to transition to XSS, that is (1) more unlikely and (2) less of an escalation (if they can inject HTML tags, they might as well inject a script or an iframe). |
Co-authored-by: Zbyszek Tenerowicz <[email protected]>
Co-authored-by: Zbyszek Tenerowicz <[email protected]>
Co-authored-by: Zbyszek Tenerowicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on addressing feedback provided by:
As well as issues that are currently open in the same context:
Thus, it includes the following PRs (by merge order):