Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Look into changing name display in dropdown #127

Open
timelsass opened this issue Mar 4, 2019 · 2 comments
Open

Look into changing name display in dropdown #127

timelsass opened this issue Mar 4, 2019 · 2 comments
Labels
Status: Possible Bug This issue is a possible bug, but might not be (could be a misunderstanding or a false positive). Type: Enhancement This is an enhancement of the existing features or a new feature to the plugin.

Comments

@timelsass
Copy link
Member

@dingo-d did a fresh install and ran build, everything tests out fine so far. One thing I noticed with multiple themes named the same in the dropdown - the calls for version and which is the active theme are I guess pulled from wp_get_theme - so they all remain the same. I looked at Theme Check, and it looks like it was resolved by naming duplicates as Theme Name/folder-name. I don't think that's a blocker though.

Originally posted by @timelsass in #125 (comment)

@timelsass timelsass changed the title Look into changing display in dropdown Look into changing name display in dropdown Mar 4, 2019
@dingo-d dingo-d added Type: Enhancement This is an enhancement of the existing features or a new feature to the plugin. Status: Possible Bug This issue is a possible bug, but might not be (could be a misunderstanding or a false positive). labels Mar 30, 2019
@dingo-d
Copy link
Member

dingo-d commented Mar 30, 2019

Should we go with this? As currently the version is added to the theme name.

@timelsass
Copy link
Member Author

The issue still exists, but it probably doesn't impact many people, more of a "would be nice" to help identify when you might have multiple of the same theme added, just they have renamed folders. The other part of this is say you copy/paste a theme folder a few times - running a scan right now - I believe the dropdown is relying on the theme's slug. Regardless of which option you choose, the slug is the same, so it only ever runs on the one main theme folder, which can be confusing if you're temporarily renaming a folder to make/test changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Possible Bug This issue is a possible bug, but might not be (could be a misunderstanding or a false positive). Type: Enhancement This is an enhancement of the existing features or a new feature to the plugin.
Projects
None yet
Development

No branches or pull requests

2 participants