Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Exclude Folder Option #145

Open
DannyCooper opened this issue Mar 16, 2019 · 5 comments
Open

Exclude Folder Option #145

DannyCooper opened this issue Mar 16, 2019 · 5 comments
Labels
Status: Future Release This issue will be fixed in the future release of the plugin, or an enhancement will be added in the Type: Enhancement This is an enhancement of the existing features or a new feature to the plugin.

Comments

@DannyCooper
Copy link

In the case where a theme is using a library (Kirki, TGMPA, etc.) it would be useful to have a text field to enter directories that shouldn't be scanned.

Examples:

/vendor
/TGMPA
/inc/kirki
@joyously
Copy link

But libraries must meet the requirements also.

@DannyCooper
Copy link
Author

Yes, but for universally accepted libraries like the ones I mentioned, they don’t need to be scanned for each theme.

Assuming they are up to date.

@joyously
Copy link

I'd rather have them scanned than give the author an option to skip stuff.
And how do you assume they are up to date without scanning?

@DannyCooper
Copy link
Author

The tool is for reviewers as much as authors. As a reviewer I’m checking the library versioning manually anyway.

@dingo-d dingo-d added Type: Enhancement This is an enhancement of the existing features or a new feature to the plugin. Status: Future Release This issue will be fixed in the future release of the plugin, or an enhancement will be added in the labels Mar 30, 2019
@dingo-d
Copy link
Member

dingo-d commented Mar 30, 2019

Currently, vendors and node_modules are excluded. The reasoning is that you may have those folders during development, but they shouldn't (vendors maybe should in some cases) be scanned as they would most certainly crash the sniffer or report on tons and tons of code that may not end up in the theme in the end.

As for kirki and TGMPA we should check them, because you never know what kind of code may be included. Somebody can say: I included TGMPA but puts his/hers own evil code inside...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Future Release This issue will be fixed in the future release of the plugin, or an enhancement will be added in the Type: Enhancement This is an enhancement of the existing features or a new feature to the plugin.
Projects
None yet
Development

No branches or pull requests

3 participants