Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit filesize upload, stop in mutex from connection continuing #24

Open
WR4F opened this issue May 5, 2020 · 2 comments
Open

Limit filesize upload, stop in mutex from connection continuing #24

WR4F opened this issue May 5, 2020 · 2 comments
Labels
bug Something isn't working Important This issue is high priority

Comments

@WR4F
Copy link
Owner

WR4F commented May 5, 2020

Users who try to upload files larger than given limit should have the upload stop if it goes past a certain filesize.

Optimal solution is to check filesize before letting the user start uploading, but it may not be that straightforward since clients can lie. Got to stop the upload the second it passes the filesize limit

@WR4F WR4F added bug Something isn't working Important This issue is high priority labels May 5, 2020
@WR4F
Copy link
Owner Author

WR4F commented May 19, 2020

I think it might be fixed in the latest version, had to switch from mutex to busboy and handle packets a more manual way. Need to test.

@WR4F
Copy link
Owner Author

WR4F commented May 28, 2020

When using nginx as a reverse proxy this continues to be an issue, but in testing environments the TCP connection is cut early by the server. This needs to be investigated further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Important This issue is high priority
Projects
None yet
Development

No branches or pull requests

1 participant