Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session.Proposal missing public access to expiryTimestamp #1359

Open
simonmcl opened this issue May 22, 2024 · 0 comments
Open

Session.Proposal missing public access to expiryTimestamp #1359

simonmcl opened this issue May 22, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@simonmcl
Copy link

Describe the bug
Recently updated to 1.18.8 from a much older version, and updating my app to use the inbuilt request queue. My intention was to query for

Sign.instance.getPendingRequests()
Sign.instance.getPendingProposals()

merge the two and sort by expiryTimestamp to see which incoming object should be actioned next. The Request object has an expiryTimestamp, but Session.proposal doesn't. One of its properties, of type SessionProposal, does but its marked internal and inaccessible. I need access to this internal property so I can queue these items up appropriately

In general, quite a lot of the SDK is marked private/internal. There are other things i've tried to do and been unable to due to these restrictions. For example when the socket disconnects, I display a spinner. I've encountered a rare bug where it doesn't disappear and i'm trying to pin down where the issue is occurring. I wanted to run a check inside viewDidAppear checking the underlying web-socket's connection status property, to check if it needs to be updated manually, but again the socket is inaccessible. I really feel like an SDK such as this should be a lot more open to allowing devs to at least have read-only access on the majority of properties, to keep integrations as flexible as possible

SDK Version

  • Client: Swift
  • Version: 1.18.8
@simonmcl simonmcl added the bug Something isn't working label May 22, 2024
@llbartekll llbartekll self-assigned this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants