From 43791ce02c8bb566915c948fd6f48d3fe8bb99fa Mon Sep 17 00:00:00 2001 From: kozyatinskiy Date: Mon, 27 Mar 2017 12:26:18 -0700 Subject: [PATCH] [inspector] finally removed *ExecuteScript from inspector We don't need hints from embedder any more. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2773143002 Cr-Commit-Position: refs/heads/master@{#44158} --- include/v8-inspector.h | 2 -- src/inspector/v8-inspector-impl.cc | 7 ------- src/inspector/v8-inspector-impl.h | 2 -- 3 files changed, 11 deletions(-) diff --git a/include/v8-inspector.h b/include/v8-inspector.h index c7209ed69aea..43bf3b4f60b1 100644 --- a/include/v8-inspector.h +++ b/include/v8-inspector.h @@ -224,8 +224,6 @@ class V8_EXPORT V8Inspector { virtual void resetContextGroup(int contextGroupId) = 0; // Various instrumentation. - virtual void willExecuteScript(v8::Local, int scriptId) = 0; - virtual void didExecuteScript(v8::Local) = 0; virtual void idleStarted() = 0; virtual void idleFinished() = 0; diff --git a/src/inspector/v8-inspector-impl.cc b/src/inspector/v8-inspector-impl.cc index 0f02b81667ff..567dff261275 100644 --- a/src/inspector/v8-inspector-impl.cc +++ b/src/inspector/v8-inspector-impl.cc @@ -239,13 +239,6 @@ void V8InspectorImpl::resetContextGroup(int contextGroupId) { m_debugger->wasmTranslation()->Clear(); } -void V8InspectorImpl::willExecuteScript(v8::Local context, - int scriptId) { -} - -void V8InspectorImpl::didExecuteScript(v8::Local context) { -} - void V8InspectorImpl::idleStarted() { for (auto it = m_sessions.begin(); it != m_sessions.end(); ++it) { if (it->second->profilerAgent()->idleStarted()) return; diff --git a/src/inspector/v8-inspector-impl.h b/src/inspector/v8-inspector-impl.h index 8ffea34e9ee2..492ec04fe4e8 100644 --- a/src/inspector/v8-inspector-impl.h +++ b/src/inspector/v8-inspector-impl.h @@ -74,8 +74,6 @@ class V8InspectorImpl : public V8Inspector { void contextCreated(const V8ContextInfo&) override; void contextDestroyed(v8::Local) override; void resetContextGroup(int contextGroupId) override; - void willExecuteScript(v8::Local, int scriptId) override; - void didExecuteScript(v8::Local) override; void idleStarted() override; void idleFinished() override; unsigned exceptionThrown(v8::Local, const StringView& message,