Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gilblins #1826

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Gilblins #1826

wants to merge 20 commits into from

Conversation

Malicos
Copy link
Contributor

@Malicos Malicos commented Nov 21, 2020 •
edited by sejtalk
Loading

Changelog:

  • Added Gilblins.

Developer changelog:

  • Argurgle, a Shath'gral gilblin now holds the Rotten Beach in Swamp of Sorrows.

TODO:

  • Portraits

How to test:

@Malicos
added gilblins
f9be46b 
Added Gilblin culture.
Added placeholder portraits for Gilblins.
@Malicos
Gilblins
12044e8 
Added Argurgle, a gilblin in Swamp of Sorrows.
Deactivated Marshfin duchy.
Rotten Beach is now Shath'gral gilblin territory.
Added Gilblin dynasties.
@Malicos
Gilblin race icon
103acff 
Added race icon for trait.
Added culture loc.
@Malicos Malicos requested a review from a team as a code owner November 21, 2020 13:34
@Malicos Malicos marked this pull request as draft November 21, 2020 13:35
@Malicos Malicos self-assigned this Nov 21, 2020
@Malicos Malicos added this to the 1.10 milestone Nov 21, 2020
@Malicos Malicos added 🎨 2D graphics 🖌️ Adding 2D graphic files or adjustments ❗ priority high Issue or addition is high priority ⭐ new feature 🆕 Adding a new feature to the mod 📄 localisation 🖊️ Adding or adjusting localisations labels Nov 21, 2020
@Malicos
Update wc_race_events.txt
daf3b55 
added race event
@Malicos
Update 000_wc_traits.csv
2aadcb3 
localization for gilblin trait
@Malicos Malicos requested a review from zumbak04 November 21, 2020 14:41
@Malicos Malicos modified the milestones: 1.10, 1.11 Dec 23, 2020
@sejtalk sejtalk marked this pull request as ready for review February 25, 2021 12:59
@sejtalk sejtalk requested review from zumbak04 and a team July 22, 2021 13:36
LordSilvermane
LordSilvermane reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@LordSilvermane LordSilvermane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few loc suggestions. Will test later today.

localisation/000_wc_traits.csv Outdated Show resolved Hide resolved
localisation/wc_culture_buildings.csv Outdated Show resolved Hide resolved
arithon
arithon approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@arithon arithon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loc LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordSilvermane LordSilvermane LordSilvermane left review comments

@arithon arithon arithon approved these changes

@zumbak04 zumbak04 Awaiting requested review from zumbak04

Assignees

@sejtalk sejtalk

@Malicos Malicos

Labels
🎨 2D graphics 🖌️ Adding 2D graphic files or adjustments ❗ priority high Issue or addition is high priority 📄 localisation 🖊️ Adding or adjusting localisations ⭐ new feature 🆕 Adding a new feature to the mod
Projects
None yet
Milestone
Patch 1.11
Development

Successfully merging this pull request may close these issues.
5 participants
@Malicos @LordSilvermane @zumbak04 @arithon @sejtalk