Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistencies in PreFreeSurferPipeline.sh with AnatomicalAverage.sh #313

Open
aureliocarnero opened this issue Oct 22, 2024 · 6 comments

Comments

@aureliocarnero
Copy link

In AnatomicalAverage.sh from PreFreeSurfer. The input Arguments have changed from -n, -o, -s, -m... to: --output, --image-list.... But this is not reflected in PreFreeSurferPipeline.sh which still expect the old format

@coalsont
Copy link
Member

I have committed e1eafb1 to master to try to fix this, give it a try.

@aureliocarnero
Copy link
Author

it worked, thanks. But now I found something else along the the PreFreeSurferPipeline.sh.
When running robustfov (line 86), before in v4.7.0 it didn't complaint (I don't know if it was executed or not) but now, it tells the brain size is not given correctly as an argument for robustfov.
To correct this, I just add the argument -b before the brain size as:

$FSLDIR/bin/robustfov -i ${fn}_reorient -r ${fn}_roi -m ${fn}_roi2orig.mat -b $BrainSizeOpt

@glasserm
Copy link
Contributor

Perhaps the FSL usage changed since this was implemented. We can fix it, but it will break old FSL versions.

Matt.

@aureliocarnero
Copy link
Author

That's true. Better not to touch anything. Therefore I'm closing the issue as resolved. If I encounter any other inconsistency in the pipeline while executing it, I will open a new issue.
Thank you

@glasserm
Copy link
Contributor

Well, we do need the pipelines to work with newer FSLs, the problem is we don't know in which version this changed, which makes it hard to maintain backwards compatibility.

@aureliocarnero
Copy link
Author

aureliocarnero commented Oct 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants