Skip to content

Commit

Permalink
Fix Issue #4 - Artifacts around landing gear - Shadows.
Browse files Browse the repository at this point in the history
Should also fix other transparent objects.
Third-party mods with similar problems with semi-transparent materials should ensure such objects are not on one of the shadowed layers, which are:
            Default = 0
            Water = 4
            Kerbals = 16
            Parts = 19
In particular, transparent lighting effects should be on layer:
            TransparentFX = 1
It is however perfectly fine for "solid" transparent objects such as glass to be shadowed; just be aware that the entire geometry gets shadow applied, not just the opaque areas.
  • Loading branch information
WazWaz committed Apr 9, 2017
1 parent 1d4d9c8 commit 204cbd6
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
3 changes: 1 addition & 2 deletions Atmosphere/Clouds2D.cs
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,7 @@ public void Reassign(Tools.Layer layer, Transform parent, float worldScale)
ShadowProjectorGO.layer = (int)layer;
if (layer == Tools.Layer.Local)
{
ShadowProjector.ignoreLayers = ~(Tools.Layer.Default.Mask() |
Tools.Layer.TransparentFX.Mask() |
ShadowProjector.ignoreLayers = ~(Tools.Layer.Default.Mask() | // Note: *NOT* TransparentFX, otherwise landing gear lights etc. look terrible.
Tools.Layer.Water.Mask() |
Tools.Layer.Local.Mask() |
Tools.Layer.Kerbals.Mask() |
Expand Down
2 changes: 1 addition & 1 deletion LocalSetup.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<KSPDir>C:\KSP\KSP_1.2.1</KSPDir>
<KSPDir>C:\KSP\KSP_1.2.2debug</KSPDir>
</PropertyGroup>
</Project>
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ EnvironmentalVisualEnhancements

Visual enhancements including clouds, lights, etc.

Developers: edit the LocalSetup.csproj to set your KSP directory.



Some portions of this project are under the GNU General Public License (DDS texture loader)
and should be distributed as-such. This project was added to replace the functionality of the
Expand Down
2 changes: 1 addition & 1 deletion _BuildManager/Properties/AssemblyVersionInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.2.1.1")] // KSP version with EVE release number appended.
[assembly: AssemblyVersion("1.2.2.1")] // KSP version with EVE release number appended.

0 comments on commit 204cbd6

Please sign in to comment.