Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create function to get pool by id #35

Open
Akshola00 opened this issue Feb 20, 2025 · 6 comments · May be fixed by #49
Open

create function to get pool by id #35

Akshola00 opened this issue Feb 20, 2025 · 6 comments · May be fixed by #49
Assignees
@Oluwaseyi89
Labels
Non_Reworded non- reworded ODBuild ODBuild

Comments

@Akshola00
Copy link
Contributor

function to get a pool by id

fn get_pool_by_id(self: @TContractState, pool_id: u32) -> PoolDetails;

write test for this function
@SoarinSkySagar
Copy link

may i start working on this one @Akshola00 ?

eta: 2 days

@bernardev254
Copy link
Contributor

hello @Akshola00,
this serves my intentions to tackle this issue.If assigned i will implement and test a function that gets pool by id

@Akshola00
Copy link
Contributor Author

hello @Akshola00,
this serves my intentions to tackle this issue.If assigned i will implement and test a function that gets pool by id

No current implementation for get pool so I can't assign this issue until get pool is done

@Oluwaseyi89
Copy link

Can I contribute to this one?

@bernardev254
Copy link
Contributor

hello @Akshola00,
this serves my intentions to tackle this issue.If assigned i will implement and test a function that gets pool by id

No current implementation for get pool so I can't assign this issue until get pool is done

We can implement the get pool first

@Akshola00 Akshola00 added Non_Reworded non- reworded ODBuild ODBuild labels Feb 26, 2025
@Oluwaseyi89
Copy link

I am still working on this issue. I shall send the Pull Request tomorrow.

@Oluwaseyi89 Oluwaseyi89 linked a pull request Feb 28, 2025 that will close this issue
Open
Oluwaseyi89 added a commit to Oluwaseyi89/predifi that referenced this issue Mar 4, 2025
@Oluwaseyi89
fix: added vercel.json and /contract/scripts/install-scarb.sh to enha…
9e5a395 
…nce build at deployment for Web3Novalabs#35
Oluwaseyi89 added a commit to Oluwaseyi89/predifi that referenced this issue Mar 5, 2025
@Oluwaseyi89
fix: modified version.json on issue Web3Novalabs#35
1d87dea
Oluwaseyi89 added a commit to Oluwaseyi89/predifi that referenced this issue Mar 5, 2025
@Oluwaseyi89
fix: modified package.json and vercel.json on Web3Novalabs#35
4eaa844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Oluwaseyi89 Oluwaseyi89

Labels
Non_Reworded non- reworded ODBuild ODBuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT: Created Function to Get Pool by Id Oluwaseyi89/predifi
4 participants
@bernardev254 @Oluwaseyi89 @Akshola00 @SoarinSkySagar