Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

There are no JS API tests here #8

Open
lars-t-hansen opened this issue Apr 9, 2018 · 2 comments
Open

There are no JS API tests here #8

lars-t-hansen opened this issue Apr 9, 2018 · 2 comments
Assignees
@binji

Comments

@lars-t-hansen
Copy link
Collaborator

The API surface to JS is actually substantial for this proposal, but I've found no test cases in this repo. We need to add them.
@binji
Copy link
Member

binji commented Apr 9, 2018

Yes, good point. I'll add some ASAP.

@binji binji self-assigned this Apr 9, 2018
@binji
Copy link
Member

binji commented Apr 27, 2018

Well, it wasn't exactly ASAP, but here are some JS API tests -- #14. I've confirmed they work against the v8 implementation (and thanks to @Cellule, I fixed a number of bugs too!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@binji binji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@binji @lars-t-hansen