Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header template/pattern nests header elements #58

Open
gratrockstar opened this issue Aug 22, 2023 · 0 comments
Open

Header template/pattern nests header elements #58

gratrockstar opened this issue Aug 22, 2023 · 0 comments

Comments

@gratrockstar
Copy link

Updated to the latest wd_f, and the header template now eventually includes a pattern.

templates/index.html: <!-- wp:template-part {"slug":"header","tagName":"header","className":"site-header"} /-->
parts/header.html: <!-- wp:pattern {"slug":"wds/header-default"} /-->
patterns/header-default.php contains <header class="wp-block-group" style="margin-top:var(--wp--preset--spacing--30);margin-bottom:var(--wp--preset--spacing--30)">

image

This results in nested header elements for the site header, and because it's a pattern, updating the header-default.php markup doesn't update the markup for the existing site header.

I'd think <header class="wp-block-group"> should be changed to <div class="wp-block-group">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant