You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The communications between the content script and the page should follow the same typescript interfaces, from here: https://github.com/WebOfTrust/polaris-web/blob/main/src/client.ts. I suggest these be added as imports, instead of redundantly maintaining separate interface definitions or inline object construction, such as the following:
Explicit constructors might also be helpful to assure constraints beyond the typescript interface, such as when a reply might be required to have a payload of one-of AID or Credential.
After reconsidering this, it's polaris-web that needs to introduce its typing's / interfaces that any extension's content script would be compatible with.
The communications between the content script and the page should follow the same typescript interfaces, from here: https://github.com/WebOfTrust/polaris-web/blob/main/src/client.ts. I suggest these be added as imports, instead of redundantly maintaining separate interface definitions or inline object construction, such as the following:
// from https://github.com/WebOfTrust/signify-browser-extension/blob/b20e1abff1fccbed62ca895411446b78dbbecd20/src/pages/content/index.tsx#L109C13-L117C15
Explicit constructors might also be helpful to assure constraints beyond the typescript interface, such as when a reply might be required to have a payload of one-of AID or Credential.
There is some overlap with the ui-events defined here: https://github.com/WebOfTrust/signify-browser-extension/blob/main/src/config/event-types.ts
These kind of changes will help assure polaris-web and signify-browser-extension adhere to consistent interfaces communications.
The text was updated successfully, but these errors were encountered: