Add ReleasableException and BuryableException

[glen-84]

These exceptions are defined in both SlmQueueBeanstalkd and SlmQueueDoctrine, which ties the job to the queue implementation.

Why not define these exceptions in SlmQueue itself?

For example, instead of:

SlmQueueBeanstalkd\Job\Exception\ReleasableException and
SlmQueueDoctrine\Job\Exception\ReleasableException

Just have:

SlmQueue\Job\Exception\ReleasableException

[juriansluiman]

Closing this now. The releasable and buryable exceptions are removed from beanstalkd to make it more natural for the queue process in general. I think it should be removed from Doctrine as well. @basz and @stefankleff, what do you think?

See for more info Webador/SlmQueueBeanstalkd#26 and this commit specifically.

[juriansluiman]

PS. Uhm, I wanted to close this as I saw the issue, but then I wrote a comment which started a discussion. So I'm not closing this one yet :)

[basz]

@juriansluiman which discussion would that be? I agree with the idea that the job can bury/release itself if the queue implementation supports it.

[juriansluiman]

@basz so we remove those exceptions from Doctrine as well?

[basz]

yes - i think it is a welkom simplification

[juriansluiman]

OK, closing now then. Webador/SlmQueueDoctrine#55 is the reference.

[stefankleff]

I agree with that. I'm currently working on some kind of monitoring tool. I'm not yet finished but I like to provide some insights as soon as possible. E.g. using the exception as return value of Job::execute() is more helpful than using constants. Also I've added forking capabilities which are not fully tested yet. goalio@37217ec