Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed : On-wiki training_slide with quiz doesn't include complete question prompt #6137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed : On-wiki training_slide with quiz doesn't include complete question prompt #6137

wants to merge 2 commits into from
+52 −5

Conversation

omChauhanDev
Copy link
Contributor

@omChauhanDev omChauhanDev commented Jan 17, 2025 •
edited
Loading

What this PR does

Fixes #5823

This PR improves quiz question formatting by:

  • Adding multi-line support for quiz content parsing
  • Removing unwanted wiki markup (colons and triple quotes) from rendered content
  • Preserving proper line breaks and paragraph formatting

Technical Changes

  • Updated template_parameter_value in WikiSlideParser to handle multi-line content
  • Modified regex pattern to safely remove wiki formatting characters
  • Added markdown processing for quiz questions in the frontend Quiz component

Screenshots

Before:
Before

After:
After

ragesoss
ragesoss reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@ragesoss ragesoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should include a new test in wiki_slide_parser_spec.rb, which fails without the update to WikiSlideParser but passes with it. The exact slide content from the bug report can probably be used for this.

lib/training/wiki_slide_parser.rb
match = template.match(/\|\s*#{parameter}\s*=\s*(?<value>.*)/)
match && match['value']
# Extract value from the template
match = template.match(/\|\s*#{parameter}\s*=\s*(?<value>.*?)(?=\||\Z)/m)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a complicated regex, so it should include comments to explain what each part is doing.

Also, the example from the comment should not be removed. If necessary, update that example or add a second one for the case this is dealing with.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@omChauhanDev
Copy link
Contributor Author

Screenshots (for test case)

Before updating WikiSlideParser:
Before

After updating WikiSlideParser:
After

Testing

  • Added new quiz with multi-line content
  • Verified formatting in both backend parsing and frontend display
  • Confirmed existing quiz functionality remains unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ragesoss ragesoss ragesoss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On-wiki training slide with quiz doesn't include complete question prompt
2 participants
@omChauhanDev @ragesoss