-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fade in and fade out animations #164
base: master
Are you sure you want to change the base?
Conversation
PXL_20230523_040736809.TS.mp4Quick preview of functionality (I know, ironic that I haven't gotten obs working yet) |
e8c678a
to
475ab70
Compare
Reference Hyprland initial animation commit: hyprwm/Hyprland@bcf7ee6 |
1aed34f
to
7ed7f29
Compare
54dc823
to
7d37b1f
Compare
Fade out currently blocks closing multiple windows until the previous window is closed. Will be fixed |
…nimation_duration
be2801e
to
e20b886
Compare
did you abandon it? |
Nope, I just got pulled away for some other needed work. I need to re attempt the fade-out |
I tested this branch a while ago, it worked pretty well... (except for weird bugs that made windows invisible). but i think another nice feature would be to make it so that you could have fading move animations. like say you have a window open. you open another, and it fades in. but instead of the previous window snapping into its new size, it would fade out the original one while simultaneously fading in the new-sized window. and maybe you could add some kind of functionality to layershell effects. e.g if mako (or any other notification daemon) redraws (or idk what its called, changes the pixels), it would fade from the previous state to the new one. in Hyprland, a notification in mako would cause mako to fade in. but when theres more than 1 notification, its just sudden. so if theres a way to do this not just with windows but redrawing certain layershell windows, i think that it could give swayfx even a bit of an edge over hyprland. although there aren't really moving animations yet, swayfx is able to give layers shadows. this could be another thing that Hyprland doesn't seem to be addressing. |
Definitely agree with what you're saying here, the movement will be easy to add once fade is in. The reason this isn't merged yet is because I'm looking into fade out issues, may need to rethink how its done with a copy of the surfaces texture |
doesn't this mako thing rely on client? |
Nice Work |
Here's an example of how it is currently: |
Gonna need some time to fix some bugs prior to a merge |
9d408f4
to
d1fe550
Compare
2f1c205
to
1d1b4fb
Compare
Looking forward to this! Thanks for the hard work! |
Me too! |
I'll ditch Hyprland for SwayFX once and for all once this gets released! |
He puts the W in Will |
Going to refocus on this once we switch to using the scene api, aka next upstream rebase. Scene should simplify this, and Erik has a POC already |
Sway 1.10 with the scene-graph API is out! :D |
We'll get a rebase + release up soon and then focus on this :) |
Closes #7
TODO: