Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new registerInserterMediaCategory API to make media categories extensible #1147

Closed
abhansnuk opened this issue Oct 11, 2023 · 7 comments
Closed
Assignees
Labels
6.4 Changes in 6.4 release [Status] Done Issue is completed
Milestone

Comments

@abhansnuk
Copy link
Collaborator

Dev Note for #51542 - standalone.

@github-actions
Copy link

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

@abhansnuk
Copy link
Collaborator Author

@ntsekouras is working on this in Make/Core CMS. Link shared to preview in ticket has expired. New link needed to draft.

@ntsekouras
Copy link

Here's the new link: https://make.wordpress.org/core/?p=108427&preview=1&_ppp=aa6e13eab3

@abhansnuk abhansnuk changed the title Add new registerInserterMediaCategory API to make media categories extensible #51542 Add new registerInserterMediaCategory API to make media categories extensible Oct 12, 2023
@shabnam611 shabnam611 added the 6.4 Changes in 6.4 release label Oct 15, 2023
@shabnam611 shabnam611 added this to the 6.4 milestone Oct 15, 2023
@abhansnuk
Copy link
Collaborator Author

Thanks @ntsekouras for all the work on this style guide. It will be interesting to developers.

For time, I have started on second reviews and have the following comments.

First paragraph: Suggest the paragraph below to replace the first one to help people searching and give context, and to avoid ending on 'from'.

"From WordPress 6.4, extenders can register their own inserter media categories and provide users with more options from which to choose."

Third paragraph: From an accessibility perspective, there have been previous conversations about whether to capitalize 'id' if not used in code in a post, to assist screen readers and those using translation tools. I can't find a noted decision on this in the documentation style book.

Fourth paragraph: could you please use words to help the reader follow where they are being sent when describing the link as we avoid 'here' as a descriptor as it is difficult for accessibility.

Fifth paragraph: 'The example...': there is an extra full stop before the colon.

Added a props holding line.

Added an excerpt.

Added 6.4 dev notes tag.

Thanks Nik.

@abhansnuk
Copy link
Collaborator Author

@ntsekouras the Marcomms team for the release are collating an email to plugin authors. This dev note may be a good one to highlight for inclusion.

@abhansnuk abhansnuk moved this from In Progress to Needs 1st Review in WP 6.4 Documentation Oct 15, 2023
@ntsekouras
Copy link

I made the small updates per the above suggestions. Feel free though to edit whatever you see fit, if they are about some rewording or in general not something technical. If it's something about code or implementation details, I can help of course with whatever needed. Thanks!

@bph bph moved this from Needs 1st Review to Done in WP 6.4 Documentation Oct 16, 2023
@bph
Copy link

bph commented Oct 16, 2023

Published: New registerInserterMediaCategory API

@bph bph closed this as completed Oct 16, 2023
@github-actions github-actions bot added the [Status] Done Issue is completed label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.4 Changes in 6.4 release [Status] Done Issue is completed
Projects
Status: Done
Development

No branches or pull requests

4 participants