Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing hard coded style tags with wp_add_inline_style #1168

Open
abhansnuk opened this issue Oct 12, 2023 · 7 comments
Open

Replacing hard coded style tags with wp_add_inline_style #1168

abhansnuk opened this issue Oct 12, 2023 · 7 comments
Labels
6.4 Changes in 6.4 release [Status] To do Issue marked as Todo
Milestone

Comments

@abhansnuk
Copy link
Collaborator

Trac ticket: https://core.trac.wordpress.org/ticket/58775

Keyword on ticket: needs-dev-note

Writer: Jonny Harris
2023/10/12 Received Dev note draft - google doc

@abhansnuk abhansnuk converted this from a draft issue Oct 12, 2023
@github-actions
Copy link

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

@abhansnuk abhansnuk moved this to Needs 1st Review in WP 6.4 Documentation Oct 12, 2023
@shabnam611 shabnam611 assigned joemcgill and abhansnuk and unassigned joemcgill and abhansnuk Oct 12, 2023
@shabnam611 shabnam611 added the 6.4 Changes in 6.4 release label Oct 15, 2023
@shabnam611 shabnam611 added this to the 6.4 milestone Oct 15, 2023
@zzap zzap added the [Status] To do Issue marked as Todo label Oct 17, 2023
@codente
Copy link

codente commented Oct 17, 2023

I've reviewed the draft also and it looks good from here!

@bph
Copy link

bph commented Oct 17, 2023

Converted to make Blog;
Public Preview link:
https://make.wordpress.org/core/?p=109034&preview=1&_ppp=d4d6b66275

@bph
Copy link

bph commented Oct 17, 2023

Little wrinkle,

Needs an author change and I couldn't make @spacedmonkey show in the drop-down list...

@nalininsbs
Copy link

Noting discussion on this in core-performance. No one else with editor access could do this either, eventhough Jonny's username is showing as Editor in users. This may be a meta bug as happened with other authors yesterday too.

@codente
Copy link

codente commented Oct 17, 2023

I can't change labels or anything but this one has been published so could be updated to reflect that it's done, I think?
https://make.wordpress.org/core/2023/10/17/replacing-hard-coded-style-tags-with-wp_add_inline_style/

@nalininsbs
Copy link

Edit thank you to Weston Ruter and Abha.

Published. Waiting for information from performance for Field Guide.

@nalininsbs nalininsbs moved this from Needs 1st Review to Done in WP 6.4 Documentation Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.4 Changes in 6.4 release [Status] To do Issue marked as Todo
Projects
Status: Done
Development

No branches or pull requests

7 participants