Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ausblick (Lesson Wrap Up) links in German lesson plan template #1952

Closed
adamwoodnz opened this issue Oct 25, 2023 · 1 comment
Closed

Fix Ausblick (Lesson Wrap Up) links in German lesson plan template #1952

adamwoodnz opened this issue Oct 25, 2023 · 1 comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Type] Bug Something isn't working on the Learn website. [Type] Good First Issue Good website development issue for new contributors.

Comments

@adamwoodnz
Copy link
Contributor

adamwoodnz commented Oct 25, 2023 •
edited
Loading

Description

The IDs in the links at the bottom of the German lesson plan template do not match links in the content

Step-by-step reproduction instructions

  1. Create a new lesson plan and insert the German lesson plan pattern
  2. Save and load the lesson plan on the frontend
  3. Scroll to the bottom and click these links

Screenshot 2023-10-26 at 11 04 40 AM

Expected behaviour

They should scroll the page to IDs existing in the page content #Exercises and #Assessment, which are expected to be section titles.

Actual behaviour

Nothing happens when clicking

The section titles should be given appropriate IDs (ubungen and quiz?) and the links updated (#ubungen and #quiz?) if they exist in the content, or else these links should be removed altogether.

See the changes made to the English template to fix this.
@adamwoodnz adamwoodnz added [Type] Bug Something isn't working on the Learn website. Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Oct 25, 2023
@adamwoodnz adamwoodnz moved this to Triaged to-dos in LearnWP Website Development Oct 25, 2023
@adamwoodnz adamwoodnz mentioned this issue Oct 25, 2023
Merged
@adamwoodnz adamwoodnz changed the title Fix ids in German lesson plan template Fix Ausblick (Lesson Wrap Up) links in German lesson plan template Oct 25, 2023
@jonathanbossenger jonathanbossenger added [Type] Good First Issue Good website development issue for new contributors. [Component] Learn Theme Website development issues related to the Learn theme. and removed Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Nov 16, 2023
@jonathanbossenger jonathanbossenger mentioned this issue Nov 20, 2023
Closed
@adamwoodnz
Copy link
Contributor Author

Closing as Lessons Plans are now deprecated.

@adamwoodnz adamwoodnz closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Type] Bug Something isn't working on the Learn website. [Type] Good First Issue Good website development issue for new contributors.
Projects
LearnWP Website Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanbossenger @adamwoodnz @kaitohm