Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Presenter Application form check box sign not proper alignment. #2221

Closed
vipulupadala-multidots opened this issue Feb 15, 2024 · 4 comments
Labels
[Dev] Has PR Website related issue that also has a related pull request.

Comments

@vipulupadala-multidots
Copy link

Type of feedback

Need to improve the check box sign design for The Tutorial Presenter Application form page.

Description

I have reviewed the meta site and during the Tutorial Presenter Application form check box design is not properly displayed. So think we need to improve some design.

Step-by-step reproduction instructions (optional)

  1. First Open the URL
  2. Select the check box and see design not displayed properly

Screenshots or screen recording (optional)

Screenshot: https://share.cleanshot.com/fK9BS8FH07DgbNPsMwKD

@vipulupadala-multidots vipulupadala-multidots added the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Feb 15, 2024
@devmuhib009
Copy link
Member

Thanks @vipulupadala-multidots for creating the issue.

@devmuhib009 devmuhib009 added the [Content] Feedback Feedback provided about content on Learn. label Feb 15, 2024
@github-project-automation github-project-automation bot moved this to Awaiting Validation in LearnWP Content - Feedback Feb 15, 2024
@devmuhib009 devmuhib009 removed the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Feb 15, 2024
vipulupadala-multidots added a commit to vipulupadala-multidots/Learn that referenced this issue Feb 15, 2024
@digitalchild digitalchild added [Dev] Has PR Website related issue that also has a related pull request. and removed [Content] Feedback Feedback provided about content on Learn. labels Feb 16, 2024
@digitalchild digitalchild moved this to Triaged to-dos in LearnWP Website Development Feb 16, 2024
@unprintedch
Copy link

I did try something.

There is couple of question in the PR. I put them back here for easy discussion.

Open questions:
How could we make a good use of sensei css variables?
I use the SVG icon in the CSS, I find it bad... (and the linter too) can someone tell me how to do it properly?
And where to put this "checkbox.scss" it is an override of a vendor, any good practice?

@unprintedch
Copy link

I just notice that there was already a PR?

@ironnysh
Copy link

ironnysh commented Sep 5, 2024

The redesign resolved this issue (tested this page in Chrome, Safari, and Firefox).

We can close the two related PRs: #2222 and #2359.

cc @jonathanbossenger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Dev] Has PR Website related issue that also has a related pull request.
Projects
Status: Done
Development

No branches or pull requests

6 participants