Notice: Function _load_textdomain_just_in_time was called incorrectly

[BhargavBhandari90]

Notice on the screen when we setup repo locally.
Notice: Function _load_textdomain_just_in_time was called incorrectly. Translation loading for the sensei-lms domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the init action or later. Please see [Debugging in WordPress](https://developer.wordpress.org/advanced-administration/debug/debug-wordpress/) for more information. (This message was added in version 6.7.0.) in /var/www/html/wp-includes/functions.php on line 6121 Notice: Function _load_textdomain_just_in_time was called incorrectly. Translation loading for the jetpack domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the init action or later. Please see [Debugging in WordPress](https://developer.wordpress.org/advanced-administration/debug/debug-wordpress/) for more information. (This message was added in version 6.7.0.) in /var/www/html/wp-includes/functions.php on line 6121

Description

When we try to setup learn site locally by following series of command given in readme.md and when we try to access site by localhost:8888, then it shows notice on the top of the screen.

Step-by-step reproduction instructions (optional)

1. Clone the repo
2. Run following commands:

• yarn
• yarn run create
• Visit site localhost:8888

3. See the top of the browser.

Screenshots or screen recording (optional)

[BhargavBhandari90]

I've quickly tried to debug this issue and found that we need following updated plugins needs to be installed:

• Jetpack
• Sensei LMS

When I updated these plugins from wp-admin, notice has gone after that.

[BhargavBhandari90]

Further debugging, I've found that we are installing pluigns via this line https://github.com/WordPress/Learn/blob/trunk/bin/index.sh#L18 ( let me know if this is correct ).

Questions:

• Why it is not installing latest plugins?
• Is it installing versions same as LIVE site?

[jonathanbossenger]

Aha, well found.

Essentially, the plugins are updated only when necessary, and we don't control which versions are installed, as that's managed by the Meta team that manages the entire .org infrastructure.

My recommendation then is to keep supressing the errors locally, eventually those plugins will get updated, and the issue will go away.

[BhargavBhandari90]

Got it. I thought the same. Closing the issue now. Thanks

[dd32]

Essentially, the plugins are updated only when necessary, and we don't control which versions are installed, as that's managed by the Meta team that manages the entire .org infrastructure.

To clarify, Meta only controls the versions deployed to learn.wordpress.org, not the versions installed locally.

Learn/bin/index.sh

Line 18 in d1bf93d

npm run wp-env run cli wp plugin activate edit-flow jetpack wordpress-importer sensei-lms gutenberg locale-detection code-syntax-block wporg-learn

When you run locally, the above wp-cli command activates the plugins, but the versions are per what was installed, per composer.
Composer is not good at this IMHO. It's not suitable for the purpose of which learn is being used in.

Learn/composer.json

Lines 70 to 75 in d1bf93d

	"wpackagist-plugin/code-syntax-block": "*",
	"wpackagist-plugin/edit-flow": "*",
	"wpackagist-plugin/gutenberg": "*",
	"wpackagist-plugin/jetpack": "*",
	"wpackagist-plugin/sensei-lms": "*",
	"wpackagist-plugin/wordpress-importer": "*",

The above specifies that any version (latest..) of those plugins should be installed, but because composer.lock exists, it uses the locked versions from there:

Learn/composer.lock

Lines 799 to 816 in d1bf93d

	{
	"name": "wpackagist-plugin/sensei-lms",
	"version": "4.24.0",
	"source": {
	"type": "svn",
	"url": "https://plugins.svn.wordpress.org/sensei-lms/",
	"reference": "tags/4.24.0"
	},
	"dist": {
	"type": "zip",
	"url": "https://downloads.wordpress.org/plugin/sensei-lms.4.24.0.zip"
	},
	"require": {
	"composer/installers": "^1.0 || ^2.0"
	},
	"type": "wordpress-plugin",
	"homepage": "https://wordpress.org/plugins/sensei-lms/"
	},

Due to the way composer works, it's not possible to install the latest version of the plugins, unless the lock file is not distributed. My personal preference is to never commit the composer.lock file to a repository, such that everyone ends up with the latest version of packages. This might be a solution for the learn repo.

I'm re-opening this, because at the minimum we probably need to update the composer.lock file.

[BhargavBhandari90]

Thanks for the information. I'll update the lock file.