Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve visibility of progress bar on video content #871

Open
kaitohm opened this issue Aug 3, 2022 · 5 comments
Open

[Enhancement] Improve visibility of progress bar on video content #871

kaitohm opened this issue Aug 3, 2022 · 5 comments
Labels
Accessibility Fix or enhancement related to accessibility. [Type] Bug Something isn't working on the Learn website. [Type] Enhancement New feature request for the Learn website.

Comments

@kaitohm
Copy link
Contributor

kaitohm commented Aug 3, 2022

Description

It's been reported (Slack conversation link) that the progress bar on videos on Learn are visually difficult to locate. This is especially so when the video content is showing the wp-admin screen... which many of our videos do. (See screenshot below.) A better interface would improve accessibility.

Step-by-step reproduction instructions

  1. Go to learn.wordpress.org
  2. Click on Tutorials
  3. Choose any tutorial and play video
  4. Progress bar is difficult to locate, and will only appear large once one has hovered over the video

Suggested improvement

  • Change color scheme (bold colors?) so it doesn't conflict with the default wp-admin screen often shown in videos.

But this is still very much open to other ideas and suggestions.

I realize this could involve enhancements to the video player we're using. I wanted to log the idea here so it doesn't get lost.

Screenshots or screen recording (optional)

Screen Shot 2022-07-29 at 15 36 43

Environment information

  • Reproduced on Chrome on MacOS
@kaitohm kaitohm added [Type] Bug Something isn't working on the Learn website. Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. Suggestion labels Aug 3, 2022
@vagelisp
Copy link
Member

vagelisp commented Aug 4, 2022

I totally agree. That can be confusing.
We can easily fix that with CSS

Blue seems to work well and fits the general design.
Screen Shot 2022-08-05 at 2 38 11 AM

@renintw
Copy link
Contributor

renintw commented Oct 19, 2022

@bsanevans
Since the video is embedded to Learn using iframe, which basically doesn't allow us to modify the CSS here in Learn as conceptually the stuff in an iframe has nothing to do with the page being embedded - it's just content from other sites. In our case, it's from wordpress.tv.

If we want to change the video's style, we must change it there. Before digging more into how we can change the style there (either by proposing ideas or making requests), I'm wondering if we are capable of trying this first https://jetpack.com/support/jetpack-videopress/jetpack-videopress-customizing-your-videos/#videopress-progress-bar-colors. I do not have permission to edit videos there, not sure if we can do the tweaks like that in the link.

@jonathanbossenger
Copy link
Collaborator

The Learn theme uses the default WordPress auto-embed functionality to embed the WordPress.tv video URL on the tutorial page

https://github.com/WordPress/Learn/blob/trunk/wp-content/themes/pub/wporg-learn-2020/template-parts/content-workshop-single.php#L32

This renders the video at full width above the content and sidebar on the tutorial (previously known as workshop) view.

If we changed this to use the VideoPress block, we'd need to extract the block on the front end to display in the same area, which I guess should be possible by extracting the video press block from the block markup in the post_content.

The other thing we'd need to do is update all current tutorials to use the VideoPress block, and not the video_url postmeta field.

I'm not saying it's not possible, just detailing what would be required to make this switch.

@bsanevans perhaps this is something we should discuss in a future training team meeting?

@vagelisp
Copy link
Member

Ahh, I didn't even realise that was coming from an iframe when I added my comment.
It must have been a late-night one. Anyway, I apologise for the misinformation.

@kaitohm kaitohm added Accessibility Fix or enhancement related to accessibility. and removed Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Nov 4, 2022
@kaitohm
Copy link
Contributor Author

kaitohm commented Nov 4, 2022

Thanks for the input, @jonathanbossenger. Considering we have other more pressing site development needs right now, I'm inclined to leave this issue as-is for the moment. We can bring it up again once we have more developers who are able to contribute to improving the Learn site.

@kaitohm kaitohm added [Type] Enhancement New feature request for the Learn website. and removed Suggestion labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Fix or enhancement related to accessibility. [Type] Bug Something isn't working on the Learn website. [Type] Enhancement New feature request for the Learn website.
Projects
Status: In discussion
Development

No branches or pull requests

4 participants