From 770fa91a19d21c7513384f8c13725dc963b87444 Mon Sep 17 00:00:00 2001 From: Vicente Canales <1157901+vcanales@users.noreply.github.com> Date: Thu, 23 May 2024 00:02:29 +0200 Subject: [PATCH] Enable shadow support for cover block On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: https://github.com/WordPress/gutenberg/issues/57103 Co-authored-by: vcanales Co-authored-by: madhusudhand --- docs/reference-guides/core-blocks.md | 2 +- packages/block-library/src/cover/block.json | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/reference-guides/core-blocks.md b/docs/reference-guides/core-blocks.md index c08869db34b484..7b7dbe92915678 100644 --- a/docs/reference-guides/core-blocks.md +++ b/docs/reference-guides/core-blocks.md @@ -245,7 +245,7 @@ Add an image or video with a text overlay. ([Source](https://github.com/WordPres - **Name:** core/cover - **Category:** media -- **Supports:** align, anchor, color (heading, text, ~~background~~, ~~enableContrastChecker~~), dimensions (aspectRatio), interactivity (clientNavigation), layout (~~allowJustification~~), spacing (blockGap, margin, padding), typography (fontSize, lineHeight), ~~html~~ +- **Supports:** align, anchor, color (heading, text, ~~background~~, ~~enableContrastChecker~~), dimensions (aspectRatio), interactivity (clientNavigation), layout (~~allowJustification~~), shadow, spacing (blockGap, margin, padding), typography (fontSize, lineHeight), ~~html~~ - **Attributes:** allowedBlocks, alt, backgroundType, contentPosition, customGradient, customOverlayColor, dimRatio, focalPoint, gradient, hasParallax, id, isDark, isRepeated, isUserOverlayColor, minHeight, minHeightUnit, overlayColor, tagName, templateLock, url, useFeaturedImage ## Details diff --git a/packages/block-library/src/cover/block.json b/packages/block-library/src/cover/block.json index eb55a8dbabec1c..0ce80ca8d424f4 100644 --- a/packages/block-library/src/cover/block.json +++ b/packages/block-library/src/cover/block.json @@ -85,6 +85,7 @@ "anchor": true, "align": true, "html": false, + "shadow": true, "spacing": { "padding": true, "margin": [ "top", "bottom" ],