Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move permalink control to sidebar once post title is a block #16412

Closed
tellthemachines opened this issue Jul 4, 2019 · 1 comment
Closed
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@tellthemachines
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The permalink control on the post title becomes unusable at high zoom levels:

59984277-a4ad5200-966b-11e9-969d-5b1bcfd0f698

Overall it makes semantic sense to have this feature in the sidebar instead of directly attached to the component, and it makes it easier to use on small screens or at high zoom levels.

Describe the solution you'd like

In #16277 it was suggested that the permalink control be moved into the sidebar. This is dependent on the post title component being a block in its own right, approaches to which are being discussed in #16281

Describe alternatives you've considered

The fix for the immediate accessibility problem is already in #16277.
However, that doesn't solve the wider problem of where it makes more sense to attach that control.

@tellthemachines tellthemachines added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Blocks Overall functionality of blocks [a11y] Zooming labels Jul 4, 2019
@Soean
Copy link
Member

Soean commented Mar 26, 2020

The permalink was removed from the title in #21099. Now it's only in the sidebar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

3 participants