-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Block: Merge horizontal and vertical nav into one block #23226
Comments
The vertical orientation of the navigation bloc is a variation because it also modifies how the block works. For instance the movers for the links in the navigation block are vertical instead of horizontal in the vertical variation. That cannot happen by simply adding a class as we need to update an attribute that can then be read and affect how the editor renders the block. |
Could you explain what are the "movers"? Hmm... that is a bummer if these two cannot be merged into one - once I started playing with FSE and creating different headers this option made the most sense to me UX-wise. On a related note, I found that the vertical menu is getting somewhat lost when using the If we're going to keep two separate navigation blocks, would it make sense to indicate orientation in the block empty state too? (right now it just says "Navigation") And would it make sense to be able to transform vertical menu to horizontal and vice versa? Let me know if it makes sense to open new issues for any of these. |
As mentioned above, the horizontal and vertical options are really Variations of the same Navigation block. As such, they appear as different (yet similar) blocks in the library: I think we should add more variations, and consider renaming the existing ones. The ideas I have in mind are:
Now, as we look at adding more variations, it becomes important to be able to switch between them. As @alaczek mentions above, the existing Transform menu could be useful here: Its a little lack luster, and doesn't really explain what the differences are between the variations, so I tried expanding them into their own group: This is likely a little too verbose. Would could condense the options down using sub-menus, and show variations like block styles: Another idea I had was to use a select element, perhaps in the block sidebar to allow you to switch variant: |
I'm closing this as this is resolved by #26687, as @draganescu also mentioned. Feel free to reopen if you think it has something else to be implemented. |
This might have already been discussed, but I was wondering why horizontal and vertical navigation are separate blocks? Would it make sense to make them two styles of the same block?
Could we remove the light and dark block styles (which are reproducible with background and text color options anyway - see #22327) and replace them with orientation? Here's a rough mockup of how this could look like:
The text was updated successfully, but these errors were encountered: