-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Navigation Block] Add introductory text to adding a new menu item #24007
Comments
Good catch!
Attached is a super quick example of the added section heading: |
@annezazu is what Noah proposed what you are expecting or were you proposing something more like a walkthrough or popover with more information? |
Ah apologies. I reacted with a heart but should have used my words ;) I dig what Noah proposed as a minimalist way to lightly introduce this interaction. I wonder if even just saying "Options" is enough in case this kind of situation happens again where a limited set of blocks can be used in the interface. It could help create some nice consistency rather than having unique headers. Minor note: I definitely think Link should be listed before Search as adding repeated links seems far more likely than a bunch of search boxes. |
In that case. I think Noah's mock works. Let's run with that. |
Sounds good to me! |
It feels like the text could even expand a bit more instead of just being a heading. In any case, this seems like a good thing to support in the inserter API (a description? a tip? a heading?) that can be optionally added when blocks are restricted (i.e. when |
Pulling in feedback from the third call for testing for the FSE program from @paaljoachim:
Helpful to think about the above context when/if this is addressed :) |
This feedback came up once more in the sixth round of testing for the FSE Outreach Program:
I've even caught myself clicking + and then starting to type a page title forgetting to first select the Page Link block. This might just be something to adjust to but a visual prompt would go a long way. |
@jasmussen what I have in mind is some help text whenever you open the inserter in a restricted area that says "These are the blocks available to insert within the {ParentBlockName} block". |
That seems like it could be a quick win, and potentially benefit other limited nesting containers such as Social Links. @vcanales @mkaz any thoughts on the level of effort this would take to build? Seems simple enough. |
@jasmussen @mtias Are you looking for something like this? Do you want to be able to customize the message per parent block, or do you think a standard message and then just switch out the name of the block it applies to? The implementation might be slightly different depending, I'm still digging in to how we might pass the property down into the QuickInserter, so much of it is abstracted within InnerBlocks it is not quite as easy as I hoped. |
A perspective.... |
The quick inserter definitely needs iteration as far as both curation of the default 6, but also how you explore additional ones. But even without that, the "Browse all" at the bottom means it isn't a dead end, so I think it could still be a quick win: This could be a fine small step to solve this ticket, so long as it isn't the end of the road. And we do want to improve the quick inserter. It is arguably the most used interface, and right now the frecency inside means that some blocks get more prominence than they deserve simply because you don't discover others to bump them down the list. So just to explore the idea, here's what it would look like if we added a custom scrollbar: Note it would have to be custom so it doesn't fade out on Mac or mobile systems, or the point is lost. Another option is to add paging dots: That 3rd option would be the same as the current "Browse all" button. |
This experience has been iterated upon SO MUCH since I opened this issue thanks to the work around a lighter experience: #34041 Here's a current view: I'm going to close this out as a result as I don't think this feedback applies anymore :) |
Describe the bug
Currently, when adding a new item to the menu, there's no prompt or introductory text to help nudge the user along. With work being done to expand the number of types of blocks that can be added to the Navigation Block, there should likely be some sort of explanation. Otherwise, it feels a bit like something is broken.
To reproduce
Steps to reproduce the behavior:
Screenshots
Here's a video of me talking through this issue (and others): https://cloudup.com/c1ChZfDf5ut
Navigation:
General block:
Editor version (please complete the following information):
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: