Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments Form: Convert button to Button Block #27740

Closed
scruffian opened this issue Dec 15, 2020 · 1 comment · Fixed by #41251
Closed

Comments Form: Convert button to Button Block #27740

scruffian opened this issue Dec 15, 2020 · 1 comment · Fixed by #41251
Assignees
@scruffian
Labels
[Block] Buttons Affects the Buttons Block [Block] Post Comments Form Affects the Comments Form Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress

Comments

@scruffian
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Buttons within the Comment Form block need custom CSS because they can't be styled using Global Styles. See WordPress/theme-experiments#114

Describe the solution you'd like
I think the button in the Comments Form should be an implementation of a Button block.
@scruffian scruffian added [Block] Buttons Affects the Buttons Block [Feature] Full Site Editing Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Dec 15, 2020
@scruffian scruffian mentioned this issue Dec 15, 2020
Open
@skorasaurus skorasaurus added the [Block] Post Comments Form Affects the Comments Form Block label Sep 17, 2021
@mtias
Copy link
Member

mtias commented May 23, 2022

This should be absorbed with the elements API for buttons.

@mtias mtias closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2022
@scruffian scruffian mentioned this issue May 23, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scruffian scruffian

Labels
[Block] Buttons Affects the Buttons Block [Block] Post Comments Form Affects the Comments Form Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Post Comments: Make the button an element button WordPress/gutenberg
3 participants
@scruffian @mtias @skorasaurus