Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate menu creation screen to add content #34778

Closed
karmatosed opened this issue Sep 13, 2021 · 5 comments
Closed

Iterate menu creation screen to add content #34778

karmatosed opened this issue Sep 13, 2021 · 5 comments
Labels
Needs Design Feedback Needs general design feedback.

Comments

@karmatosed
Copy link
Member

karmatosed commented Sep 13, 2021

This is based on the latest trunk for this experimental feature, so I am aware that this might be a work in progress. Still, I think there are several areas where things could perhaps be improved and avoid confusing interaction patterns. I am going to create separate issues for these not to confuse them. The first of these is having 2 links (or more) on one screen.

original01

This above interface can get even more complicated when you have existing menus:

2021-09-13 at 13 02

Whilst, I don't think having a drop-down is the ultimate solution, and I think there's room for further exploring, I think it's better than having links in this case. Here is my starting idea for discussion:

iterare02

I am also aware that what I am proposing isn't new and builds on previous work around this interface; I'd love input, though if there is a direction planned, I do not see for these screens I found. I know with existing menus we need a two-step process if have drop-downs for example.

@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Sep 13, 2021
@javierarce
Copy link
Contributor

javierarce commented Sep 17, 2021

Thanks for this review, @karmatosed!

There was a short conversation around that screen in this (already closed) pull request, so this issue is great to bring out some ideas from there.

In my opinion, we should get rid of this state and instead show an empty menu. That will simplify the process of creating navigations (but to explain what this screen is about to new users, we'll need to implement a Welcome Guide)

My motivation to remove that screen is that it won't really be needed when we add bulk insertion. Once we have that feature in place, the option to "Add all pages" will be less valuable.

Regarding the last option (Copy existing menu), @Mamaduka mentioned that:

If the current goal is to achieve parity with the "old" navigation screen, I think we can remove the "Copy existing menu" option. It doesn't exist on the current screen.

I agree and I also think that a "duplicate menu" option that was always available will be more helpful for users.

@karmatosed
Copy link
Member Author

In my opinion, we should get rid of this state and instead show an empty menu. That will simplify the process of creating navigations (but to explain what this screen is about to new users, we'll need to implement a Welcome Guide)

I think I'd need to see that idea of using the welcome guide instead, but I'm super curious about it. I certainly think this screen isn't the best.

My motivation to remove that screen is that it won't really be needed when we add bulk insertion. Once we have that feature in place, the option to "Add all pages" will be less valuable.

Whilst I understand that, it is an expected pattern in WordPress, I think we could find people therefore assuming it would be there to add all. That doesn't mean it has to be on this screen, though - I can't recall if there was an easy 'select all' on the bulk adding because perhaps that solves this.

What do you think we could do to iterate what we have now and bridge the experience to get to the idea?

@javierarce
Copy link
Contributor

javierarce commented Sep 17, 2021

I can't recall if there was an easy 'select all' on the bulk adding because perhaps that solves this.

I added a "Remove selected" from my designs instead of a "Select all" because the new interface could allow selecting items from different types, and with the layout, I proposed there wasn't much space for a "Select all" option. That said, I could rethink that part of my design.

What do you think we could do to iterate what we have now and bridge the experience to get to the idea?

I think the steps could be:

  • Design and implement a Welcome Guide
  • Design and implement a "Duplicate menu" option
  • Release the Bulk inserter
  • Remove the menu creation screen

@karmatosed
Copy link
Member Author

I proposed there wasn't much space for a "Select all" option. That said, I could rethink that part of my design.

I slightly want to see what that could look like but I'm concerned if you are about limited space. I come back to it's an expected path for some users, which is why I would love to not remove it totally.

@kathrynwp
Copy link

Closing this issue due to the Navigation Screen project being moved to an inactive status on the feature projects page in coordination with the project leads. (The developer documentation in the initial post are no longer accessible)

If this work is picked back up, issues can be revisited and reopened as needed. Thanks for pitching in on this early feature so the wider WordPress project could benefit from the lessons learned!

@kathrynwp kathrynwp closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

3 participants