-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document title when opening a page via Site Editor's Navigation panel is a bit confusing #48641
Comments
Here's a first pass: Editing a template alone
Editing Page template with specific page loaded Editing Single Post template with specific post loaded Editing Archive template with specific tag loaded
The template chip appears first because the primary tab in the Inspector will continue to be 'Template'. I don't think the content chip needs to be interactive to begin with. But in the future it might serve as a tool to help illustrate whether the selected block is part of the template, part of the content, or both. Rough example: context.mp4When the selected block does not affect a scope, the associated chip is de-emphasised. |
This is definitely the key pain point to resolve. With navigation in place, are we ready to just lean fully into being content first? In that world we wouldn't be showing what page/post a template has loaded but rather which template a post/page has applied. After clicking a page name in navigation I'd expect to see that listed first in toolbar. In future we may not even want to show template name in toolbar and introduce an "edit template" step to get there. If it's a collection based page (like tag), the approach here works really well. To summarise thoughts
|
My feeling is that we can follow up to get the ordering right. I lean towards putting template first only because the Inspector will still indicate that you're editing the template: Of course we should 'fix' that too, but doing so likely needs a dedicated effort to figure out details like whether to display both tabs. |
A few different strands coming together here:
The latter I've seen a mockup that's a bit like this: I quite like your mockups here, Jay, with the content/template split. On a separate sketch I believe from Saxon, he also introduced the purple template color, to good effect: The two approaches (command bar vs. breadcrumbs) seem at odds, though, at least in the current designs. Can they be reconciled? The gray round-rect could certainly become smaller, but which of the two items in the breadcrumb would be invoked on ⌘K? |
I think there's a general question to be answered about how much emphasis the UI should place on template editing during a content editing flow. Having played a bit with this branch I'm beginning to think that the top bar placement might be a bit too prominent, so I lean more towards the 'url bar' approach (containing a single label). For the label, perhaps that should be linked with the out-of-view details panel – IE whatever is loaded into that panel is used for the label in the url bar. When it's a template, we can potentially use the purple colorisation. |
Hey folks 👋 I'm going to punt this enhancement to WP 6.3. The enhancements are rarely shipped with minor versions. |
Here's a list of things the doc title could allow a user to do:
Doesn't have to do all of these, but would be good to narrow down on the function. |
To connect some dots, I created a mockup in #50378 (comment) that overlaps a bit with this one. Should we consolidate? |
Yup closing #50378 will fix this. |
A long time ago in a galaxy far far away there was a switching mechanic in the site editor Top Toolbar that allowed you to load arbitrary content into the selected template, it looked a bit like this:
Later this was removed in order to focus more on the template editing experience.
However, with the addition of the Navigation panel, it once again becomes possible to load different items of content into a template, albeit via slightly different flow. There results an issue with the optics... it's a bit confusing when you go to edit your "Blog" page and find the subsequent title to be "Index":
page.mp4
It might make sense to restore the labelling from before, whereby users can interpret not only which template they're editing, but the content too.
The text was updated successfully, but these errors were encountered: