Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document title when opening a page via Site Editor's Navigation panel is a bit confusing #48641

Closed
jameskoster opened this issue Mar 1, 2023 · 9 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts.

Comments

@jameskoster
Copy link
Contributor

A long time ago in a galaxy far far away there was a switching mechanic in the site editor Top Toolbar that allowed you to load arbitrary content into the selected template, it looked a bit like this:

Screenshot 2023-03-01 at 14 51 51

Later this was removed in order to focus more on the template editing experience.

However, with the addition of the Navigation panel, it once again becomes possible to load different items of content into a template, albeit via slightly different flow. There results an issue with the optics... it's a bit confusing when you go to edit your "Blog" page and find the subsequent title to be "Index":

page.mp4

It might make sense to restore the labelling from before, whereby users can interpret not only which template they're editing, but the content too.

@jameskoster jameskoster added the Needs Design Needs design efforts. label Mar 1, 2023
@jameskoster jameskoster added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Mar 1, 2023
@jameskoster
Copy link
Contributor Author

Here's a first pass:

Editing a template alone

  • Layout icon indicates you’re editing a template
  • Template details popover appears on click

Editing Page template with specific page loaded

Editing Single Post template with specific post loaded

Editing Archive template with specific tag loaded

  • Template chip accompanied by associated content chip
  • Content icon helps clarify between posts, pages, category / tag archives, etc.
  • Long titles get truncated

The template chip appears first because the primary tab in the Inspector will continue to be 'Template'.

I don't think the content chip needs to be interactive to begin with. But in the future it might serve as a tool to help illustrate whether the selected block is part of the template, part of the content, or both. Rough example:

context.mp4

When the selected block does not affect a scope, the associated chip is de-emphasised.

@jameskoster jameskoster added the Needs Design Feedback Needs general design feedback. label Mar 1, 2023
@SaxonF
Copy link
Contributor

SaxonF commented Mar 2, 2023

it's a bit confusing when you go to edit your "Blog" page and find the subsequent title to be "Index":

This is definitely the key pain point to resolve. With navigation in place, are we ready to just lean fully into being content first? In that world we wouldn't be showing what page/post a template has loaded but rather which template a post/page has applied. After clicking a page name in navigation I'd expect to see that listed first in toolbar. In future we may not even want to show template name in toolbar and introduce an "edit template" step to get there.

If it's a collection based page (like tag), the approach here works really well.

To summarise thoughts

  • Introduce icon
  • If editing a "page" (entry via navigation panel), show page name first. In future, if we do introduce an "edit template" action, consider showing just page name
  • otherwise (entry via templates panel) show template name first

@jameskoster
Copy link
Contributor Author

My feeling is that we can follow up to get the ordering right. I lean towards putting template first only because the Inspector will still indicate that you're editing the template:

Screenshot 2023-03-02 at 10 43 06

Of course we should 'fix' that too, but doing so likely needs a dedicated effort to figure out details like whether to display both tabs.

@ndiego ndiego moved this from 📥 Todo to 🐛 Punted to 6.2.1 in WordPress 6.2 Editor Tasks Mar 8, 2023
@jasmussen jasmussen moved this to Todo 6.2 in 6.3 Design Mar 16, 2023
@jasmussen jasmussen moved this from Todo 6.2 to Todo in 6.3 Design Mar 16, 2023
@jameskoster jameskoster moved this from Needs design to Needs feedback in 6.3 Design Mar 22, 2023
@annezazu annezazu moved this to 🎨 Needs design in Gutenberg Phase 2: Customization Mar 22, 2023
@jasmussen
Copy link
Contributor

A few different strands coming together here:

  • Content/template split as mainly mocked up here
  • "Command bar" access

The latter I've seen a mockup that's a bit like this:

Search bar

I quite like your mockups here, Jay, with the content/template split. On a separate sketch I believe from Saxon, he also introduced the purple template color, to good effect:

Screenshot 2023-04-12 at 14 13 28

The two approaches (command bar vs. breadcrumbs) seem at odds, though, at least in the current designs. Can they be reconciled? The gray round-rect could certainly become smaller, but which of the two items in the breadcrumb would be invoked on ⌘K?

@jameskoster
Copy link
Contributor Author

with the content/template split

I think there's a general question to be answered about how much emphasis the UI should place on template editing during a content editing flow.

Having played a bit with this branch I'm beginning to think that the top bar placement might be a bit too prominent, so I lean more towards the 'url bar' approach (containing a single label).

For the label, perhaps that should be linked with the out-of-view details panel – IE whatever is loaded into that panel is used for the label in the url bar. When it's a template, we can potentially use the purple colorisation.

@Mamaduka
Copy link
Member

Hey folks 👋

I'm going to punt this enhancement to WP 6.3. The enhancements are rarely shipped with minor versions.

@Mamaduka Mamaduka moved this from 🐛 Punted to 6.2.1 to 🦵 Punted to 6.3 in WordPress 6.2 Editor Tasks Apr 13, 2023
@mtias
Copy link
Member

mtias commented May 1, 2023

Here's a list of things the doc title could allow a user to do:

  • Quick jump to other pages or templates or recently visited ones (command center).
  • Rename the page or change the URL.
  • Could absorb a "view" link.
  • Template / Content association.

Doesn't have to do all of these, but would be good to narrow down on the function.

@jasmussen
Copy link
Contributor

To connect some dots, I created a mockup in #50378 (comment) that overlaps a bit with this one. Should we consolidate?

@jameskoster
Copy link
Contributor Author

Yup closing #50378 will fix this.

@github-project-automation github-project-automation bot moved this from 🦵 Punted to 6.3 to ✅ Done in WordPress 6.2 Editor Tasks May 9, 2023
@github-project-automation github-project-automation bot moved this from 🎨 Needs design to ✅ Done in Gutenberg Phase 2: Customization May 9, 2023
@github-project-automation github-project-automation bot moved this from Needs feedback to Needs dev in 6.3 Design May 9, 2023
@jameskoster jameskoster moved this from Needs dev to Done in 6.3 Design May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts.
Projects
Status: Done
Status: Done
Development

No branches or pull requests

5 participants