Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert additional "Typesets" panel in Site Editor > Typography #65575

Closed
richtabor opened this issue Sep 23, 2024 · 1 comment
Closed

Revert additional "Typesets" panel in Site Editor > Typography #65575

richtabor opened this issue Sep 23, 2024 · 1 comment
Assignees
@jffng
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes [Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Regression Related to a regression in the latest release

Comments

@richtabor
Copy link
Member

Revert #62539, which creates a standalone nested "Typeset" panel within the Site Editor > Typography panel. It was a good attempt, but in practice just makes the UI more complicated by requiring more effort to discover these.

I'd expect the typography variations to reside top-level in the Typography panel, like this:

CleanShot 2024-09-23 at 12 28 35
@richtabor richtabor added [Type] Regression Related to a regression in the latest release [Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Typography Font and typography-related issues and PRs labels Sep 23, 2024
@richtabor richtabor moved this to 🗣️ In Discussion / Needs Decision in WordPress 6.7 Editor Tasks Sep 23, 2024
@richtabor richtabor moved this from 🗣️ In Discussion / Needs Decision to 📥 Todo in WordPress 6.7 Editor Tasks Sep 23, 2024
@jffng jffng self-assigned this Sep 23, 2024
@jffng jffng mentioned this issue Sep 23, 2024
Merged
@jffng
Copy link
Contributor

jffng commented Sep 27, 2024

Closed by #65579.

@jffng jffng closed this as completed Sep 27, 2024
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.7 Editor Tasks Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jffng jffng

Labels
[Feature] Theme Style Variations Related to style variations provided by block themes [Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Regression Related to a regression in the latest release
Projects
WordPress 6.7 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richtabor @jffng