Template level blocks can be unlocked and moved when template preview is active

[fabiankaegy]

In WordPress 6.7 there is a regression in the handling of Blocks that are part of the template but that remain editable.

For example the post title or the post featured image blocks remain editable when they are part of the template when the "Show Template" option is enabled in the editor.

In WordPress 6.7 these blocks now suddenly show a lock icon in their block toolbar. Clicking that allows editors to unlock and then move them.

This moving doesn't get persisted luckily. But it still created a broken editorial experience for users.

CleanShot.2024-11-18.at.13.56.18.mp4

[fabiankaegy]

Looking further into this it appears this has already been fixed in Gutenberg. So we need to find the PR and add that to the backport list

[youknowriad]

Hey folks, this seems to be a 6.7 only bug, I can't reproduce on Gutenberg trunk. I think it might be related to the block toolbar updates that were done specifically on that branch. Any ideas @getdave @ellatrix

[getdave]

Nothing springs to mind. There was a lot of divergence between trunk and wp/6.7 during the Beta/RC period as trunk continued to evolve in/around Zoom Out and changes to "Write mode" so it would have been easy for something to have been missed.

Also cc @cbravobernal who is leading 6.7.X releases from Editor side.

[getdave]

I noticed isDefaultEditingMode seems to be missing from the packages/block-editor/src/components/block-toolbar/index.js file in wp/6.7 but it is there in trunk.

gutenberg/packages/block-editor/src/components/block-toolbar/index.js

Lines 205 to 209 in c43a0c9

	isDefaultEditingMode &&
	showLockButtons && (
	<BlockLockToolbar
	clientId={ blockClientId }
	/>

I tried adding it in and it seemed to fix things.

Haven't had much time to test but here is a PR

[t-hamano]

#66200, which was manually backported to wp/6.7, appears to be related.

Here, both isDefaultEditingMode and isContentOnlyEditingMode were removed. The removal of isContentOnlyEditingMode seems to have been intentional, but the removal of isDefaultEditingMode might not have been.

[getdave]

So can we tweak #67121 to resolve?

[cbravobernal]

Punting this to 6.8 as it seems there won't have time to fix it for 6.7.2.

[youknowriad]

Well in that case, we should close it since it works normally on trunk right?

[t-hamano]

Yes, I think this issue can be closed.

@cbravobernal #67121 targets the wp/6.7 branch and has already been merged, so the problem reported in this issue should be fixed in WP 6.7.2