From 4873ddbd86122b56c5941d9e6314e4e065aae537 Mon Sep 17 00:00:00 2001 From: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Date: Fri, 9 Sep 2022 12:56:42 +1000 Subject: [PATCH] Layout: Fix issue with fallback gap styles where gap was being output for constrained layout type --- lib/compat/wordpress-6.1/class-wp-theme-json-6-1.php | 4 ++-- .../src/components/global-styles/use-global-styles-output.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/compat/wordpress-6.1/class-wp-theme-json-6-1.php b/lib/compat/wordpress-6.1/class-wp-theme-json-6-1.php index 9a23ee94cd6a75..68e0dd32187afa 100644 --- a/lib/compat/wordpress-6.1/class-wp-theme-json-6-1.php +++ b/lib/compat/wordpress-6.1/class-wp-theme-json-6-1.php @@ -1358,8 +1358,8 @@ protected function get_layout_styles( $block_metadata ) { // If the block should have custom gap, add the gap styles. if ( null !== $block_gap_value && false !== $block_gap_value && '' !== $block_gap_value ) { foreach ( $layout_definitions as $layout_definition_key => $layout_definition ) { - // Allow skipping default layout for themes that opt-in to block styles, but opt-out of blockGap. - if ( ! $has_block_gap_support && 'default' === $layout_definition_key ) { + // Allow outputting fallback gap styles for flex layout type when block gap support isn't available. + if ( ! $has_block_gap_support && 'flex' !== $layout_definition_key ) { continue; } diff --git a/packages/edit-site/src/components/global-styles/use-global-styles-output.js b/packages/edit-site/src/components/global-styles/use-global-styles-output.js index d9cf6020e65049..831ea5aa23ba7e 100644 --- a/packages/edit-site/src/components/global-styles/use-global-styles-output.js +++ b/packages/edit-site/src/components/global-styles/use-global-styles-output.js @@ -321,8 +321,8 @@ export function getLayoutStyles( { if ( gapValue && tree?.settings?.layout?.definitions ) { Object.values( tree.settings.layout.definitions ).forEach( ( { className, name, spacingStyles } ) => { - // Allow skipping default layout for themes that opt-in to block styles, but opt-out of blockGap. - if ( ! hasBlockGapSupport && 'default' === name ) { + // Allow outputting fallback gap styles for flex layout type when block gap support isn't available. + if ( ! hasBlockGapSupport && 'flex' !== name ) { return; }