This pull request changed or added PHP files in previous commits, but none have been detected in the latest commit.

Thank you! ❤️

Size Change: +104 B (0%)

Total Size: 1.69 MB

_{compressed-size-action}

@vcanales

Now that #57654 has been merged, I'd love to see movement toward the blocks listed in the original post: Columns, Cover, Group, Image.

I have custom block styles currently which handle this, but I'd love for it to be supported by core natively.

Would it be possible to add box shadow support to the Column block as well? I believe this would be a valuable addition to enhance individual column styling.

@vcanales

Now that #57654 has been merged, I'd love to see movement toward the blocks listed in the original post: Columns, Cover, Group, Image.

This PR now enables support for those blocks, plus the Column block, and except the group block, which is in progress.
I would appreciate any testing that can be done towards getting support for the blocks you mention, and more.

We can use this WordPress Playground link to the Gutenberg PR previewer in order to play around with the changes introduced here.

Would it be possible to add box shadow support to the Column block as well? I believe this would be a valuable addition to enhance individual column styling.

Noted, and added!

It works well in testing except when they are in side a group block.

Scenario 1:
Add a group block and image block inside it, and apply shadow to the image from block settings.

Scenario 2:
Add another image block with in the same group block and observe that the first image has no issues.

Scenario 3:
Add two group blocks and one image block inside each of them.

I expected it to work as scenario 1 (shadow getting trimmed) for both group blocks (as they contain single image).
But the shadow works for the first group block, and it doesn't for the second one.

Note: This happens only in the editor. No issues in the frontend.

Flaky tests detected in 10e89bf.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7782529319
📝 Reported issues:

• [Flaky Test] aria-disabled is correctly hydrated for different values #54370 in /test/e2e/specs/interactivity/directive-bind.spec.ts

It works well in testing except when they are in side a group block.

Investigated further on this. This is happening because of next group (when it has background), shadow goes under the next block and not visible because of the background.

This is a theme specific issue and can be ignored.

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @bgardner.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: vcanales, madhudollu, dianeco.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: bgardner.

Co-authored-by: vcanales <[email protected]>
Co-authored-by: madhusudhand <[email protected]>
Co-authored-by: dianeco <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.