Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false versus False #124

Open
tomjn opened this issue Jan 13, 2019 · 2 comments
Open

false versus False #124

tomjn opened this issue Jan 13, 2019 · 2 comments

Comments

@tomjn
Copy link
Collaborator

tomjn commented Jan 13, 2019

I suspect that the reason that provisioning doesn't work unless you provision everything is because shyaml returns True or False for boolean values, but the provisioner checks for false:

if [[ `wme_provision_site "${SITE_DOMAIN}"` == 'false' ]]; then
	echo "Provisioning of ${SITE_DOMAIN} skipped"
	return
fi

I would also keep in mind that searching in subfolders for provisioners is slower, and the goal of the VVV project longterm is to deprecate such behaviour.

A provision/vvv-init.sh or a .vvv/vvv-init.sh that calls these other provisioners would greatly improve provisioning speed, and future proof things. VVV searches 3 folders deep at the moment, but if either of those folders/files exist, it will load them and skip the file system search, which can be particularly slow on older computers

@iandunn
Copy link
Member

iandunn commented Jan 15, 2019

Thanks Tom, that's very helpful insight!

@tomjn
Copy link
Collaborator Author

tomjn commented Jan 15, 2019

If in doubt you can vagrant ssh and run the shyaml command to see exactly what it returns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants