Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of items in admin media pages #5175

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

krysal
Copy link
Member

@krysal krysal commented Nov 20, 2024

Fixes

Fixes #5174 by @krysal

Description

This PR adds pagination to the media views in the admin and prevents showing more than 50 entries at once. So the API doesn't break when trying to access them.

Testing Instructions

  1. just api/up
  2. Import reported audio-related tables. I created these TSV files from the staging DB using TablePlus and imported them locally using the same software. It's a little cumbersome because it's a table-by-table import (5 tables), but it works!
  3. Go to http://localhost:50280/admin/api/audio/ and see the pagination.

Screenshot 2024-11-20 at 13-42-10 Select audio track to change Django site admin

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog PRs) or the media properties generator (ov just catalog/generate-docs media-props for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API labels Nov 20, 2024
@krysal krysal requested a review from a team as a code owner November 20, 2024 17:44
@krysal krysal requested review from obulat and dhruvkb and removed request for a team November 20, 2024 17:44
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me some time to set the environment correctly, but I got it working. The changes make sense and work as expected. Hope this will fix the production 🤞

@krysal krysal merged commit ceed798 into main Nov 22, 2024
75 checks passed
@krysal krysal deleted the fix/admin_images_view branch November 22, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

Django's image admin view times out
2 participants