Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Block: Migrate over default block styles as theme.json settings #99

Closed
scruffian opened this issue Nov 27, 2020 · 2 comments
Closed
Assignees

Comments

@scruffian
Copy link
Collaborator

scruffian commented Nov 27, 2020

These are the video block styles:

.wp-block-video {

	figcaption {
		color: var(--global--color-primary);
		font-size: var(--global--font-size-xs);
		margin-top: calc(0.5 * var(--global--spacing-unit));
		margin-bottom: var(--global--spacing-unit);
		text-align: center;
	}
}

I don't think we need to migrate these styles as Gutenberg already has them.

* > figure > video {
	max-width: unset;
	width: 100%;
	vertical-align: middle;
}

The bottom styles are being migrated to Gutenberg: WordPress/gutenberg#27328

Broken out of #82

@scruffian scruffian self-assigned this Nov 27, 2020
@scruffian
Copy link
Collaborator Author

WordPress/gutenberg#27328 is merged so I think we can close this and mark the video block as done. @kjellr does that make sense to you?

@kjellr
Copy link
Collaborator

kjellr commented Dec 1, 2020

Yeah, that sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants