Skip to content
This repository has been archived by the owner on May 23, 2018. It is now read-only.

Class entry-content div contains too much #470

Open
chrisaldrich opened this issue Jun 7, 2016 · 7 comments
Open

Class entry-content div contains too much #470

chrisaldrich opened this issue Jun 7, 2016 · 7 comments
Labels

Comments

@chrisaldrich
Copy link

It appears that the <div class="entry-content"> spans more content than it should. (I'm actually a bit surprised that a modern facing theme like TwentySixteen doesn't fully support microformats 2 instead of the older microformats1 spec.)

Specifically I think that the entry-content div should end before the following functionalities when they're included:
<div class="sharedaddy> (Jetpack's Share This functionality),
<div id="jp-relatedposts"> (Jetpack's related posts functionality)
<div class-"author-info"> (Gravatar author information)

Essentially the semantic class "entry-content" should only contain the content written in the body of a post by the user and shouldn't really include the additional information by these other plugins.

As an example, by having entry-content include these additional pieces, users, when syndicating content semantically to other services like Tumblr, Facebook, or even RSS readers, will include this additional (often unwanted content). See also:
kylewm/KnownReactions#11 (comment)
dshanske/syndication-links#23

Cross Reference: http://microformats.org/wiki/hentry

@karmatosed
Copy link
Member

Personally, I don't see the issue with using entry-content as we are in this case.

@dshanske
Copy link

I would have to agree with @chrisaldrich that entry content should be limited to the content itself.

@miklb
Copy link

miklb commented Jun 14, 2016

Personally, I don't see the issue with using entry-content as we are in this case.

It's wrong and not semantic.

+1 for @chrisaldrich proposal.

@dshanske
Copy link

This is just a matter of having entry-content just surround the_content.

@petermolnar
Copy link

entry-content should be content only, unless the sharing buttons are considered to be part of the content; they shouldn't be though.

@karmatosed
Copy link
Member

I still don't agree as everything is 'content' so that's a really weird statement to claim 'only content should be there' - if we're being correct language wise. However, I'm also not seeing a patch for us to test the implications of this.

A good next step would be to have such a patch and then we can iterate. I do worry about what impact moving something like this has at this stage of the theme's life on child themes and other plugins. We should test that and also test on other devices.

@dshanske
Copy link

dshanske commented Jul 9, 2016

I could try my hand at it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants