-
Notifications
You must be signed in to change notification settings - Fork 111
Add width, block gap and spacing presets #34
Comments
Pinging @beafialho @jasmussen @richtabor for visibility. |
Gaps should mostly be min/max values, not hard integers. |
Thanks for creating this issue. I confirm those are the widths. Block gap I am still unsure if this will look as I intend in the editor, but we could try 20px and see how that looks. Could you clarify what you mean with this? Do they have to be
I think only Large, Extra Large and XXLarge need to be fluid. I added min and max values in the Figma library, they can be seen in the right sidebar: |
I thought it was best practice to use relative units. |
I generally prefer that fonts and vertical spacing is done in relative units, and gaps and horizontal spacing is done in fixed units. This is largely because if a font size is increased by the user, it can become very problematic if the gaps and margins grow in the same way, making text line lengths decrease to a point that they're simply unreadable. |
Fix units for spacing is fine, as long as they're using min/max. |
I don't know where in the Figma interface this is or if you are talking about something that is not already shared in this issue. |
If you already know which min() or clamp() values that are expected, kindly provide those. |
One more question 😄 |
Sorry for not being clearer @carolinan. Here's a quick screen recording of where those spacing presets are specified in the Figma file. I also just checked that these are published as a library, so you should be able to see them. spacing-presets.mp4 |
Figma link: https://www.figma.com/design/dzGCSntVch4EQdVERTqyVK/Twenty-Twenty-Five?node-id=77-7931&t=qC1CDiog2u4tpIsg-4
I am interpreting the Figma file as follows:
Width
contentSize 645px
wideSize 1340px
Block gap
Spacing presets
Note that the slugs must be numeric.
One spacing preset that results in 20px (1.25 rem) on small/mobile screens and 50px (3.125 rem) on desktop,
used to set the horizontal distance between the content and the edge of the browser.
Besides that, I do not know which of these must be fluid and what their min and max values need to be:
Extra tiny: 5px
Tiny: 10px
Extra small: 20px
Small: 30px
Regular: 50px
Large: 70px
Extra lage: 90px
XXL: 140px
The text was updated successfully, but these errors were encountered: