Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Add 404 template #39

Closed
carolinan opened this issue Aug 16, 2024 · 4 comments
Closed

Add 404 template #39

carolinan opened this issue Aug 16, 2024 · 4 comments
Assignees
@up1512001
Labels
[Component] Templates

Comments

@carolinan
Copy link
Contributor

Figma Link:

https://www.figma.com/design/dzGCSntVch4EQdVERTqyVK/Twenty-Twenty-Five?node-id=3142-998&t=qClGa6ofM1L6v4bG-4

  • Use the default header and footer template parts
  • Create the content as a pattern since the text needs to be translation ready.
    • The pattern should have "Inserter" set to "no" in the pattern file header
    • The name of the file should be hidden-404.php and should match the slug: twentytwentyfive/hidden-404.php
@up1512001
Copy link
Member

Hi @carolinan, can I work on this 404 pattern?

@carolinan
Copy link
Contributor Author

Yes, no need to ask.

@carolinan
Copy link
Contributor Author

Someone else already started working on it, perhaps you can collaborate and help with the review.

@juanfra juanfra linked a pull request Aug 19, 2024 that will close this issue
Add 404 template #56
Closed
@carolinan
Copy link
Contributor Author

This template has been added, thanks everyone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@up1512001 up1512001

Labels
[Component] Templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 404 template cliffralessio/twentytwentyfive
3 participants
@juanfra @carolinan @up1512001