Link underline thickness inconsistency across post terms and author

[beafialho]

If you notice, post author name has a thicker underline than categories. This is happening in all style variations.

[carolinan]

In the editor, only the author name is an actual link. It uses the custom CSS that the theme adds to all links:

a {
	text-decoration-thickness: 1px !important;
	text-underline-offset: .1em;
}

The post term is a span, so it does not use the link styles.

[beafialho]

Can we match the look of all the link underlines?

[carolinan]

I don't understand what you mean.
The category is only a link on the front. In the editor it is not a link underline.

[carolinan]

I think you may be suggesting that in the editor stylesheet, this CSS

/*
 * Link styles
 * https://github.com/WordPress/gutenberg/issues/42319
 */
a {
	text-decoration-thickness: 1px !important;
	text-underline-offset: .1em;
}

Should apply to all blocks that have the text decoration option set to underline.

[carolinan]

I did a very quick test.
When the text-decoration option is enabled on the block, there is no class name that we can target with CSS.

The only thing we have to identify that the option is enabled, is this inline style on the block:
style="text-decoration: underline;"

[juanfra]

Hi @beafialho - Thank you for opening this one. I can see this is noticeable in the editor's context. Here's a screencast of how I see it on trunk

Screen.Recording.2024-10-22.at.14.42.55.mov

I also remember there was an issue to customize the links so that they were "less rough". But now I'm a bit in doubt about what the expectation would be for links.

Can you please confirm what the expected behavior is when fixing this issue? We have two open PRs for this, one that's fixing the display in the editor so that there's no difference between the post terms and author, and the other approach where we are adjusting the links site-wide.

Screencast of this PR

Screen.Recording.2024-10-22.at.14.56.53.mov

---

Screencast of this PR

Screen.Recording.2024-10-22.at.14.57.27.mov

[beafialho]

Thank you! I just tested both. It seems that links in #616 work as intended 👍

[carolinan]

The category is not a link in the Site Editor, with 616 the editor and front does not match.

[juanfra]

I believe we can apply #615 on top of #616 then, as they both can coexist. Nevermind, I just checked and it's not possible.