Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try: Reduce the number of groups in landing pages to improve zoom out experience. #667

Closed
wants to merge 3 commits into from

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Nov 5, 2024

Description

Fixes #664

We're using a <main> wrapper for the landing pages with a block gap of zero, so that the different sections are editable in zoom-out view.

Screenshots

Screen.Recording.2024-11-05.at.12.28.31.mov

Testing Instructions

  1. Create a page.
  2. Insert a landing page. Choose from: "Shop homepage", "Business homepage", "Landing page for book", "Landing page for event", "Landing page for podcast".
  3. Confirm that the design is ok.
  4. Confirm that the styles of the main sections of the landing pages are accessible in zoom out view.

Copy link

github-actions bot commented Nov 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: richtabor <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Nov 5, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@juanfra juanfra added the [Type] Bug An existing feature does not function as intended. label Nov 5, 2024
@juanfra juanfra requested a review from beafialho November 5, 2024 11:40
@jasmussen
Copy link
Contributor

Gave this a quick test in the site editor > pages > new flow, and I'm seeing a different issue there, where only the business homepage can be selected:

2024-11-05 12 53 52 tt5 local 92ff6d758240

I'm also still seeing the redundant groups here:

Screenshot 2024-11-05 at 12 54 35

Did I test things wrong, here?

Thanks for the PR!

@juanfra
Copy link
Member Author

juanfra commented Nov 5, 2024

I see. In that flow, the content is already the "main", so we would have two "main" and the fix won't work.

I'm also still seeing the redundant groups here:

Those are coming from the pattern.

Edit: In the flow of creating a page and inserting the landings, we'll also have the markup with two <main> elements and that creates accessibility problems.

@jasmussen
Copy link
Contributor

Any instincts, @richtabor ?

@juanfra
Copy link
Member Author

juanfra commented Nov 5, 2024

Closing in favor of #669

I also cherry-picked the other fixes and created a PR here.

@juanfra juanfra closed this Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full page patterns have redundant nested groups which makes section styles unpredictable
2 participants